From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx1.redhat.com ([209.132.183.28]:54644 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757937Ab1KROgw (ORCPT ); Fri, 18 Nov 2011 09:36:52 -0500 Message-ID: <4EC66D7B.7030908@RedHat.com> Date: Fri, 18 Nov 2011 09:36:43 -0500 From: Steve Dickson MIME-Version: 1.0 To: Trond Myklebust CC: David Howells , jmorris@redhat.com, keyrings@linux-nfs.org, linux-nfs@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Keyrings] [PATCH] KEYS: Allow special keyrings to be cleared References: <20111111160753.5190.36069.stgit@warthog.procyon.org.uk> In-Reply-To: <20111111160753.5190.36069.stgit@warthog.procyon.org.uk> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-nfs-owner@vger.kernel.org List-ID: Hey Trond, Could you please add this patch to David's patch set? tia, steved. Author: Steve Dickson Date: Fri Nov 18 09:29:17 2011 -0500 KEYS: allow keys to be revoked from the keyring To aid in cleaning up invalid id mappings add the write bit to the key permission. Allowing only root will be able to revoke the keys. Signed-off-by: Steve Dickson diff --git a/fs/nfs/idmap.c b/fs/nfs/idmap.c index 47d1c6f..652238c 100644 --- a/fs/nfs/idmap.c +++ b/fs/nfs/idmap.c @@ -185,7 +185,7 @@ static ssize_t nfs_idmap_request_key(const char *name, size_t nam } rcu_read_lock(); - rkey->perm |= KEY_USR_VIEW; + rkey->perm |= KEY_USR_VIEW|KEY_USR_WRITE; ret = key_validate(rkey); if (ret < 0)