From: Boaz Harrosh <bharrosh@panasas.com>
To: Jim Rees <rees@umich.edu>
Cc: Srinivas KANDAGATLA <srinivas.kandagatla@st.com>,
<linux-nfs@vger.kernel.org>, <akpm@linux-foundation.org>,
<mingo@redhat.com>, <neilb@suse.de>, <stuart.menefy@st.com>
Subject: Re: [RFC:PATCH 3.1.0] do_mount: Add mount retry option for nfs root mount.
Date: Wed, 25 Jan 2012 20:51:12 +0200 [thread overview]
Message-ID: <4F204F20.5080809@panasas.com> (raw)
In-Reply-To: <20120125183200.GA26907@umich.edu>
On 01/25/2012 08:32 PM, Jim Rees wrote:
> Boaz Harrosh wrote:
>
> On 01/25/2012 04:50 PM, Srinivas KANDAGATLA wrote:
> > From: Srinivas Kandagatla <srinivas.kandagatla@st.com>
> >
> > This patch adds mountretry kernel parameter for nfs root mount.
> > mount retry indicates the number of times nfs root mount attempts to be
> > made before giving up. If this option is not specified, the default
> > value of 3 retries is used.
> >
>
> If the system is set to have root on NFS. And the root is not found
> what does it do? does it Just bums out with a recovery console?
>
> So what better options does it have other then retry for ever. die?
>
> I always thought that was inconsistent. With an hard mount NFS
> will never give up and will retry for ever freezing all IOers until
> the server came back. Only with root-mount it gives up.
>
> Please explain what is the benefits of giving up at all. Can a machine
> be at all usable without it's root?
>
> Doesn't grub have some fallback logic in case the given kernel/root fails?
If grub has one set, then it can also put a parameter to specify the retry count.
(I do like this patch)
> Also, don't you want some indication that it's not working other than just a
> blank screen?
Sure print like hell on every loop bigger then 5 (And sleep between trys)
but keep trying until interrupted (alt+ctrl+delete)
I'm just saying that the default should be "max_uint" not 5
Just my $0.017
Boaz
next prev parent reply other threads:[~2012-01-25 18:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-25 14:50 [RFC:PATCH 3.1.0] do_mount: Add mount retry option for nfs root mount Srinivas KANDAGATLA
2012-01-25 15:45 ` Jim Rees
2012-01-26 7:56 ` Srinivas KANDAGATLA
2012-01-26 8:37 ` Boaz Harrosh
2012-01-26 8:51 ` Srinivas KANDAGATLA
2012-01-26 11:08 ` Boaz Harrosh
2012-01-26 14:35 ` Srinivas KANDAGATLA
2012-01-25 16:20 ` Boaz Harrosh
2012-01-25 18:32 ` Jim Rees
2012-01-25 18:51 ` Boaz Harrosh [this message]
2012-01-25 18:52 ` Chuck Lever
2012-01-25 19:04 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F204F20.5080809@panasas.com \
--to=bharrosh@panasas.com \
--cc=akpm@linux-foundation.org \
--cc=linux-nfs@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=neilb@suse.de \
--cc=rees@umich.edu \
--cc=srinivas.kandagatla@st.com \
--cc=stuart.menefy@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).