From: Bryan Schumaker <bjschuma@netapp.com>
To: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
Cc: "Schumaker, Bryan" <Bryan.Schumaker@netapp.com>,
"bfields@fieldses.org" <bfields@fieldses.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 1/3] NFS: Fall back on old idmapper if request_key() fails
Date: Tue, 07 Feb 2012 10:54:55 -0500 [thread overview]
Message-ID: <4F31494F.7060201@netapp.com> (raw)
In-Reply-To: <1328569500.23323.5.camel@lade.trondhjem.org>
On 02/06/12 18:05, Myklebust, Trond wrote:
> On Thu, 2012-01-26 at 16:54 -0500, bjschuma@netapp.com wrote:
>> From: Bryan Schumaker <bjschuma@netapp.com>
>>
>> This patch removes the CONFIG_NFS_USE_NEW_IDMAPPER compile option.
>> First, the idmapper will attempt to map the id using /sbin/request-key
>> and nfsidmap. If this fails (if /etc/request-key.conf is not configured
>> properly) then the idmapper will call the legacy code to perform the
>> mapping. I left a comment stating where the legacy code begins to make
>> it easier for somebody to remove in the future.
>>
>> Signed-off-by: Bryan Schumaker <bjschuma@netapp.com>
>> ---
>> I tested this on both Archlinux with nfs-utils 1.2.5 and on Fedora with
>> nfs-utils 1.2.6-rc6. It did what was expected in both cases.
>>
>
> It didn't apply on top of the namespace changes. Can you please check if
> my attempt at fixing it up is correct? You'll find it in the 'devel'
> branch of my git repository.
Looks like both patches still work.
- Bryan
>
>
next prev parent reply other threads:[~2012-02-07 15:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 21:54 [PATCH 1/3] NFS: Fall back on old idmapper if request_key() fails bjschuma
2012-01-26 21:54 ` [PATCH 2/3] NFS: Keep idmapper include files in one place bjschuma
2012-02-06 23:05 ` Myklebust, Trond
2012-01-26 21:54 ` [PATCH 3/3] NFS: Update idmapper documentation bjschuma
2012-01-26 21:56 ` [PATCH 1/3] NFS: Fall back on old idmapper if request_key() fails J. Bruce Fields
2012-01-26 21:57 ` Bryan Schumaker
2012-02-06 23:05 ` Myklebust, Trond
2012-02-07 15:54 ` Bryan Schumaker [this message]
2012-02-07 19:12 ` Jeff Layton
2012-02-07 19:21 ` Myklebust, Trond
2012-02-07 19:29 ` Bryan Schumaker
2012-02-07 19:44 ` Myklebust, Trond
2012-02-07 20:05 ` Myklebust, Trond
2012-02-08 12:04 ` Jeff Layton
2012-02-08 13:50 ` Myklebust, Trond
2012-02-08 18:56 ` Myklebust, Trond
2012-02-08 19:30 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F31494F.7060201@netapp.com \
--to=bjschuma@netapp.com \
--cc=Bryan.Schumaker@netapp.com \
--cc=Trond.Myklebust@netapp.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).