linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gregor Gruener <ggruner@redhat.com>
To: linux-nfs@vger.kernel.org
Subject: [PATCH 2.6.32-131.6.1.el6.x86_64] idmapd.c: deactivate the ASCII characters check
Date: Thu, 23 Feb 2012 10:16:28 +0100	[thread overview]
Message-ID: <4F4603EC.9030404@redhat.com> (raw)

Customers are using Unicode characters umlauts (ö,ä,ü) in group names and this
creates problems with NFS ID Mapping. Groups with umlauts will be redirected to
the group NFS "nobody".
This patch deactivate the ASCII characters check. It's maybe more like a temporary fix and I think it would be nicer to
adjust the check to support Unicode characters instead to deactivate the check.

========================================================================================================

diff -Nurp nfs-utils-1.2.2/utils/idmapd/idmapd.c nfs-utils-1.2.2-fag/utils/idmapd/idmapd.c
--- nfs-utils-1.2.2/utils/idmapd/idmapd.c	2010-02-18 13:35:00.000000000 +0100
+++ nfs-utils-1.2.2-fag/utils/idmapd/idmapd.c	2011-10-05 09:09:05.815103100 +0200
@@ -850,9 +850,6 @@ validateascii(char *string, u_int32_t le
  	for (i = 0; i<  len; i++) {
  		if (string[i] == '\0')
  			break;
-
-		if (string[i]&  0x80)
-			return (-1);
  	}

  	if ((i>= len) || string[i] != '\0')



=========================================================================================================




Developer's Certificate of Origin 1.1

         By making a contribution to this project, I certify that:

         (a) The contribution was created in whole or in part by me and I
             have the right to submit it under the open source license
             indicated in the file; or

         (b) The contribution is based upon previous work that, to the best
             of my knowledge, is covered under an appropriate open source
             license and I have the right under that license to submit that
             work with modifications, whether created in whole or in part
             by me, under the same open source license (unless I am
             permitted to submit under a different license), as indicated
             in the file; or

         (c) The contribution was provided directly to me by some other
             person who certified (a), (b) or (c) and I have not modified
             it.

         (d) I understand and agree that this project and the contribution
             are public and that a record of the contribution (including all
             personal information I submit with it, including my sign-off) is
             maintained indefinitely and may be redistributed consistent with
             this project or the open source license(s) involved.

Signed-off-by: Gregor Gruener<ggruner@redhat.com>


             reply	other threads:[~2012-02-23  9:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-23  9:16 Gregor Gruener [this message]
2012-02-23 13:02 ` [PATCH 2.6.32-131.6.1.el6.x86_64] idmapd.c: deactivate the ASCII characters check Jim Rees
2012-02-28 19:55   ` J. Bruce Fields
2012-02-29 20:48 ` Steve Dickson
2012-02-29 21:38   ` Jim Rees
2012-03-01 15:22     ` Steve Dickson
2012-05-17 17:40   ` Sorin Faibish
2012-05-17 17:43   ` pNFS block performance evaluation (sorry for the wrong subject title) Sorin Faibish
2012-05-18  9:37     ` tao.peng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F4603EC.9030404@redhat.com \
    --to=ggruner@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).