From: Steve Dickson <SteveD@redhat.com>
To: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] Get normalized paths for comparing NFS export paths
Date: Mon, 05 Mar 2012 10:03:40 -0500 [thread overview]
Message-ID: <4F54D5CC.5050402@RedHat.com> (raw)
In-Reply-To: <20120305144743.GA31639@us.ibm.com>
On 03/05/2012 09:47 AM, Malahal Naineni wrote:
> Steve Dickson [SteveD@redhat.com] wrote:
>>
>>> Which is why I'm asking you if you can't copy from /proc/mounts. Distros
>>> which already have a symlink betweek /etc/mtab and /proc/mounts don't
>>> have any of these problems...
>>>
>> Personally I think it simpler to just normalize the paths before
>> writing it to the mtab verses open up and searching /proc/mounts
>> esp on client where there is large amount of mounts...
>
> We always open up and search /proc/mounts today for the matching
> mountpoint to know the exact version of nfs, right?
Yes, we open up /proc/mount to get the authoritative version.
> The umount time normalization is going to cost us?
Nothing... but I thought it might be easier to do the
normalization after a successful v4 iff the the mtab
is writable.
> Or you proposing a patch that is going to avoid opening up /proc/mounts altogether?
No... umount has to open /proc/mounts...
steved.
prev parent reply other threads:[~2012-03-05 15:03 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 1:42 [PATCH] Check for beginning '/' in the mount path Malahal Naineni
2012-02-03 11:15 ` Boaz Harrosh
2012-02-03 12:16 ` NeilBrown
2012-02-03 14:29 ` Malahal Naineni
2012-02-05 11:03 ` Boaz Harrosh
2012-02-06 18:11 ` Malahal Naineni
2012-02-07 20:44 ` [PATCH] Get normalized paths for comparing NFS export paths Malahal Naineni
2012-02-16 18:09 ` Malahal Naineni
2012-03-02 19:10 ` Steve Dickson
2012-03-02 19:27 ` Malahal Naineni
2012-03-02 20:57 ` Steve Dickson
2012-03-02 22:01 ` Malahal Naineni
2012-03-03 17:39 ` Steve Dickson
2012-03-03 19:12 ` Myklebust, Trond
2012-03-04 22:31 ` Steve Dickson
2012-03-04 22:46 ` Myklebust, Trond
2012-03-04 23:08 ` Steve Dickson
2012-03-05 4:46 ` Malahal Naineni
2012-03-05 12:03 ` Steve Dickson
2012-03-04 22:58 ` Steve Dickson
2012-03-04 23:26 ` Myklebust, Trond
2012-03-05 0:03 ` Steve Dickson
2012-03-05 2:04 ` Myklebust, Trond
2012-03-05 4:53 ` Malahal Naineni
2012-03-05 11:55 ` Steve Dickson
2012-03-05 14:47 ` Malahal Naineni
2012-03-05 15:03 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F54D5CC.5050402@RedHat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).