From: Boaz Harrosh <bharrosh@panasas.com>
To: "Myklebust, Trond" <Trond.Myklebust@netapp.com>,
"Bhamare, Sachin" <sbhamare@panasas.com>
Cc: NFS list <linux-nfs@vger.kernel.org>,
open-osd <osd-dev@open-osd.org>,
Benny Halevy <bhalevy@tonian.com>,
Steve Dickson <steved@redhat.com>,
"Welch, Brent" <welch@panasas.com>
Subject: Re: [PATCH 3/4] pnfs-obj: autologin: Add support for protocol autologin
Date: Mon, 19 Mar 2012 20:10:58 -0700 [thread overview]
Message-ID: <4F67F542.50906@panasas.com> (raw)
In-Reply-To: <4F67DA7E.80307@panasas.com>
On 03/19/2012 06:16 PM, Boaz Harrosh wrote:
> Subject: [PATCH] SQUASHME: pnf-obj: Fix as according to Trond's comments
>
<snip>
> * Don't wait for ever for osd_login to finish, only wait osd_login_upcall_timeout
> number of seconds, else fail.
OK I'm dropping this thing for now. The call to call_usermodehelper_xxx infrastructure
is not built for this.
What happens is that the (*cleanup) function passed to call_usermodehelper_fns is always
call from within the call_usermodehelper_fns(), before it's return. If it's waiting
for the execution - UMH_WAIT_EXEC - then just after execution, if UMH_WAIT_PROC then
after the program ends, if UMH_NO_WAIT it is called immediately. So there is no event
out of the kmode.c subsystem that can always notify us when the PROC ended.
For that I will need to either spun yet another thread, (The call_usermodehelper_exec
already spuns 3. Or change call_usermodehelper_exec to receive a third vector that
will be called on PROC completion. (Which will be redundant if UMH_WAIT_PROC)
Since both options are too heavyweights for me right now, I will leave this option
to a TODO, and drop the timeout support for now.
Trond please confirm.
Thanks
Boaz
next prev parent reply other threads:[~2012-03-20 3:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 6:17 [PATCHSET 0/4] Auto-login support for the pnfs-objects protocol Boaz Harrosh
2012-03-16 6:19 ` [PATCH 1/4] pnfsd-exofs: Add autologin support to exofs Boaz Harrosh
2012-03-16 6:30 ` Boaz Harrosh
2012-03-16 6:21 ` [PATCH 2/4] pnfs-obj: Remove unused variable from objlayout_get_deviceinfo() Boaz Harrosh
2012-03-16 6:23 ` [PATCH 3/4] pnfs-obj: autologin: Add support for protocol autologin Boaz Harrosh
2012-03-16 21:40 ` Myklebust, Trond
2012-03-19 20:58 ` Boaz Harrosh
2012-03-19 21:12 ` Myklebust, Trond
2012-03-19 23:23 ` Boaz Harrosh
2012-03-20 1:16 ` Boaz Harrosh
2012-03-20 3:10 ` Boaz Harrosh [this message]
2012-03-20 3:26 ` Boaz Harrosh
2012-03-20 3:47 ` [PATCH version2] " Boaz Harrosh
2012-03-16 6:27 ` [PATCH 4/4] osd_login: Add autologin script for objlayoutdriver Boaz Harrosh
2012-03-23 2:36 ` SQUASHME: " Boaz Harrosh
2012-03-23 2:57 ` [PATCH version2] " Boaz Harrosh
2012-05-01 18:50 ` [PATCH 4/4] " Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F67F542.50906@panasas.com \
--to=bharrosh@panasas.com \
--cc=Trond.Myklebust@netapp.com \
--cc=bhalevy@tonian.com \
--cc=linux-nfs@vger.kernel.org \
--cc=osd-dev@open-osd.org \
--cc=sbhamare@panasas.com \
--cc=steved@redhat.com \
--cc=welch@panasas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).