[PATCH] rpc.gssd: Links directly with libgssapi_krb5 which not needed.

[PATCH] rpc.gssd: Links directly with libgssapi_krb5 which not needed.

[Steve Dickson]

rpc.gssd and rpc.svcgssd both link with the libgssapi_krb5 and
libgssglue libraries which is not needed since libgssglue
will dynamically load the gssapi interface defined in the
/etc/gssapi_mech.conf. Most likely the libgssapi_krb5 library.

Signed-off-by: Steve Dickson <steved@redhat.com>
---
 aclocal/kerberos5.m4 |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/aclocal/kerberos5.m4 b/aclocal/kerberos5.m4
index dfa5738..7574e2d 100644
--- a/aclocal/kerberos5.m4
+++ b/aclocal/kerberos5.m4
@@ -31,7 +31,7 @@ AC_DEFUN([AC_KERBEROS_V5],[
     fi
     if test "$K5CONFIG" != ""; then
       KRBCFLAGS=`$K5CONFIG --cflags`
-      KRBLIBS=`$K5CONFIG --libs gssapi`
+      KRBLIBS=`$K5CONFIG --libs`
       K5VERS=`$K5CONFIG --version | head -n 1 | awk '{split($(4),v,"."); if (v@<:@"3"@:>@ == "") v@<:@"3"@:>@ = "0"; print v@<:@"1"@:>@v@<:@"2"@:>@v@<:@"3"@:>@ }'`
       AC_DEFINE_UNQUOTED(KRB5_VERSION, $K5VERS, [Define this as the Kerberos version number])
       if test -f $dir/include/gssapi/gssapi_krb5.h -a \
-- 
1.7.7.5

Re: [PATCH] rpc.gssd: Links directly with libgssapi_krb5 which not needed.

[J. Bruce Fields]

On Thu, Jan 26, 2012 at 03:07:41PM -0500, Steve Dickson wrote:
> rpc.gssd and rpc.svcgssd both link with the libgssapi_krb5 and
> libgssglue libraries which is not needed since libgssglue
> will dynamically load the gssapi interface defined in the
> /etc/gssapi_mech.conf. Most likely the libgssapi_krb5 library.
> 
> Signed-off-by: Steve Dickson <steved@redhat.com>
> ---
>  aclocal/kerberos5.m4 |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/aclocal/kerberos5.m4 b/aclocal/kerberos5.m4
> index dfa5738..7574e2d 100644
> --- a/aclocal/kerberos5.m4
> +++ b/aclocal/kerberos5.m4
> @@ -31,7 +31,7 @@ AC_DEFUN([AC_KERBEROS_V5],[
>      fi
>      if test "$K5CONFIG" != ""; then
>        KRBCFLAGS=`$K5CONFIG --cflags`
> -      KRBLIBS=`$K5CONFIG --libs gssapi`
> +      KRBLIBS=`$K5CONFIG --libs`

OK, so that's gathering krb5-config output which gives us the list of -l
switches we need to link in kerberos libraries, and removing the
"gssapi" argument has the effect of removing "-lgssapi_krb5" from the
output.

Ack, I guess, except: I'm a little confused why we want to link with
*any* kerberos libraries, if rpc.gssd and rpc.svcgssd are supposed to
themselves be completely mechanism-independent and are supposed to
dlopen() aything they need for kerberos.

--b.

>        K5VERS=`$K5CONFIG --version | head -n 1 | awk '{split($(4),v,"."); if (v@<:@"3"@:>@ == "") v@<:@"3"@:>@ = "0"; print v@<:@"1"@:>@v@<:@"2"@:>@v@<:@"3"@:>@ }'`
>        AC_DEFINE_UNQUOTED(KRB5_VERSION, $K5VERS, [Define this as the Kerberos version number])
>        if test -f $dir/include/gssapi/gssapi_krb5.h -a \
> -- 
> 1.7.7.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] rpc.gssd: Links directly with libgssapi_krb5 which not needed.

[Steve Dickson]

On 01/26/2012 03:30 PM, J. Bruce Fields wrote:
> On Thu, Jan 26, 2012 at 03:07:41PM -0500, Steve Dickson wrote:
>> rpc.gssd and rpc.svcgssd both link with the libgssapi_krb5 and
>> libgssglue libraries which is not needed since libgssglue
>> will dynamically load the gssapi interface defined in the
>> /etc/gssapi_mech.conf. Most likely the libgssapi_krb5 library.
>>
>> Signed-off-by: Steve Dickson <steved@redhat.com>
>> ---
>>  aclocal/kerberos5.m4 |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/aclocal/kerberos5.m4 b/aclocal/kerberos5.m4
>> index dfa5738..7574e2d 100644
>> --- a/aclocal/kerberos5.m4
>> +++ b/aclocal/kerberos5.m4
>> @@ -31,7 +31,7 @@ AC_DEFUN([AC_KERBEROS_V5],[
>>      fi
>>      if test "$K5CONFIG" != ""; then
>>        KRBCFLAGS=`$K5CONFIG --cflags`
>> -      KRBLIBS=`$K5CONFIG --libs gssapi`
>> +      KRBLIBS=`$K5CONFIG --libs`
> 
> OK, so that's gathering krb5-config output which gives us the list of -l
> switches we need to link in kerberos libraries, and removing the
> "gssapi" argument has the effect of removing "-lgssapi_krb5" from the
> output.
Right...

> 
> Ack, I guess, except: I'm a little confused why we want to link with
> *any* kerberos libraries, if rpc.gssd and rpc.svcgssd are supposed to
> themselves be completely mechanism-independent and are supposed to
> dlopen() aything they need for kerberos.
Well when they are not liked with any kerberos libs the following
are undefined http://fpaste.org/rWOR/

I'm treading on a thin ice here but I'm thinking those undefines are
not part the gssapi. Only the gssapi routines are dynamically linked.

Thanks for the time!

steved.

Re: [PATCH] rpc.gssd: Links directly with libgssapi_krb5 which not needed.

[Kevin Coffman]

On Thu, Jan 26, 2012 at 4:50 PM, Steve Dickson <SteveD@redhat.com> wrote:
>
>
> On 01/26/2012 03:30 PM, J. Bruce Fields wrote:
>> On Thu, Jan 26, 2012 at 03:07:41PM -0500, Steve Dickson wrote:
>>> rpc.gssd and rpc.svcgssd both link with the libgssapi_krb5 and
>>> libgssglue libraries which is not needed since libgssglue
>>> will dynamically load the gssapi interface defined in the
>>> /etc/gssapi_mech.conf. Most likely the libgssapi_krb5 library.
>>>
>>> Signed-off-by: Steve Dickson <steved@redhat.com>
>>> ---
>>>  aclocal/kerberos5.m4 |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/aclocal/kerberos5.m4 b/aclocal/kerberos5.m4
>>> index dfa5738..7574e2d 100644
>>> --- a/aclocal/kerberos5.m4
>>> +++ b/aclocal/kerberos5.m4
>>> @@ -31,7 +31,7 @@ AC_DEFUN([AC_KERBEROS_V5],[
>>>      fi
>>>      if test "$K5CONFIG" != ""; then
>>>        KRBCFLAGS=`$K5CONFIG --cflags`
>>> -      KRBLIBS=`$K5CONFIG --libs gssapi`
>>> +      KRBLIBS=`$K5CONFIG --libs`
>>
>> OK, so that's gathering krb5-config output which gives us the list of -l
>> switches we need to link in kerberos libraries, and removing the
>> "gssapi" argument has the effect of removing "-lgssapi_krb5" from the
>> output.
> Right...
>
>>
>> Ack, I guess, except: I'm a little confused why we want to link with
>> *any* kerberos libraries, if rpc.gssd and rpc.svcgssd are supposed to
>> themselves be completely mechanism-independent and are supposed to
>> dlopen() aything they need for kerberos.
> Well when they are not liked with any kerberos libs the following
> are undefined http://fpaste.org/rWOR/
>
> I'm treading on a thin ice here but I'm thinking those undefines are
> not part the gssapi. Only the gssapi routines are dynamically linked.
>
> Thanks for the time!

Most of those functions are dealing with finding credentials caches
and keytabs and examining them.  (Trying to pick the right credential
cache to use, and trying to find the right keytab entry to use...)  As
Steve said, those are strictly Kerberos functions, not GSSAPI.

K.C.

Re: [PATCH] rpc.gssd: Links directly with libgssapi_krb5 which not needed.

[Steve Dickson]

On 01/26/2012 03:07 PM, Steve Dickson wrote:
> rpc.gssd and rpc.svcgssd both link with the libgssapi_krb5 and
> libgssglue libraries which is not needed since libgssglue
> will dynamically load the gssapi interface defined in the
> /etc/gssapi_mech.conf. Most likely the libgssapi_krb5 library.
> 
> Signed-off-by: Steve Dickson <steved@redhat.com>
Committed... 

> ---
>  aclocal/kerberos5.m4 |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/aclocal/kerberos5.m4 b/aclocal/kerberos5.m4
> index dfa5738..7574e2d 100644
> --- a/aclocal/kerberos5.m4
> +++ b/aclocal/kerberos5.m4
> @@ -31,7 +31,7 @@ AC_DEFUN([AC_KERBEROS_V5],[
>      fi
>      if test "$K5CONFIG" != ""; then
>        KRBCFLAGS=`$K5CONFIG --cflags`
> -      KRBLIBS=`$K5CONFIG --libs gssapi`
> +      KRBLIBS=`$K5CONFIG --libs`
>        K5VERS=`$K5CONFIG --version | head -n 1 | awk '{split($(4),v,"."); if (v@<:@"3"@:>@ == "") v@<:@"3"@:>@ = "0"; print v@<:@"1"@:>@v@<:@"2"@:>@v@<:@"3"@:>@ }'`
>        AC_DEFINE_UNQUOTED(KRB5_VERSION, $K5VERS, [Define this as the Kerberos version number])
>        if test -f $dir/include/gssapi/gssapi_krb5.h -a \