From: Boaz Harrosh <bharrosh@panasas.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: "Myklebust, Trond" <Trond.Myklebust@netapp.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] NFSv4: Change the default setting of the nfs4_disable_idmapping parameter
Date: Thu, 22 Mar 2012 15:11:46 -0700 [thread overview]
Message-ID: <4F6BA3A2.1090501@panasas.com> (raw)
In-Reply-To: <20120322212616.GD23737@fieldses.org>
On 03/22/2012 02:26 PM, J. Bruce Fields wrote:
> On Thu, Mar 22, 2012 at 09:01:12PM +0000, Myklebust, Trond wrote:
>> On Thu, 2012-03-22 at 16:53 -0400, Trond Myklebust wrote:
>>> Does the idmapper do the right thing for numeric ids these days? If the
>>> older clients are running a newer idmapper that can deal with numeric
>>> ids, then even the legacy clients should be able to work cleanly.
>>
>> If this isn't the case, then the older clients are broken anyway. The
>> server has always had the option of returning numeric ids if it has no
>> mapping from a uid/gid into an owner/group string.
>
> Hm, yes, but I was worried that the id<->name mapping might just be
> different on the two sides--but if that's so, and they were using
> auth_sys, then they likely already had problems.
>
> So, maybe we could default this to on.
>
> If that's the case then I'd rather not bother making this per export:
> just an option to get the server back to its previous behavior would
> seem enough.
>
> --b.
>
>> IOW: the only difference between older and newer clients should really
>> be that the newer ones handle numeric strings more efficiently without
>> requiring an upcall, and that the newer clients will also try to _send_
>> numeric ids in SETATTR calls.
>>
I was thinking about this too. Trond was making this clearer.
Could we have an on/off/auto option? on the server.
The auto option is start with off, and if the client
"_send_ numeric ids in SETATTR calls" then this client will start to be
treated as on.
Though now that I see it in writing it looks too complicated. Just a crazy
thought I had.
If you ask me I vote for default on, because where it makes a difference
from my experience with old Server the setup had a problem. Now all of a
sudden it will magically work. I fail to see an opposite scenario where
the brokenness was good, and now it will be bad.
Thanks
Boaz
>> --
>> Trond Myklebust
>> Linux NFS client maintainer
>>
>> NetApp
>> Trond.Myklebust@netapp.com
>> www.netapp.com
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-03-22 22:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 19:45 [PATCH] NFSv4: Change the default setting of the nfs4_disable_idmapping parameter Trond Myklebust
2012-03-22 20:47 ` J. Bruce Fields
2012-03-22 20:53 ` Myklebust, Trond
2012-03-22 21:01 ` Myklebust, Trond
2012-03-22 21:26 ` J. Bruce Fields
2012-03-22 22:11 ` Boaz Harrosh [this message]
2012-03-22 22:16 ` Boaz Harrosh
2012-03-26 15:36 ` J. Bruce Fields
2012-03-22 21:09 ` J. Bruce Fields
2012-03-22 20:54 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6BA3A2.1090501@panasas.com \
--to=bharrosh@panasas.com \
--cc=Trond.Myklebust@netapp.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox