linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Boaz Harrosh <bharrosh@panasas.com>
To: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
Cc: "Matt W. Benjamin" <matt@linuxbox.com>,
	linux-nfs <linux-nfs@vger.kernel.org>,
	Ganesha NFS List <nfs-ganesha-devel@lists.sourceforge.net>
Subject: Re: unlink within an open directory stream
Date: Mon, 26 Mar 2012 11:43:43 -0700	[thread overview]
Message-ID: <4F70B8DF.9000108@panasas.com> (raw)
In-Reply-To: <1332786347.17253.33.camel@lade.trondhjem.org>

On 03/26/2012 11:25 AM, Myklebust, Trond wrote:

> On Mon, 2012-03-26 at 11:17 -0700, Boaz Harrosh wrote:
>> On 03/24/2012 10:12 AM, Myklebust, Trond wrote:
>>
>>
>> It's the new (post RHEL 6.0 Kernel) NFS need for opendir after an unlink.
> 
> What?
> 


The links below report on regression in RHEL 6.2 which have a new NFS
implementation where  6.0 used to be fine.
(Or it's what I understood from the reporters)

<snip>

> 

> No.
> 
> If the server supports permanent readdir cookies, then there is no need
> for opendir after unlink.
> 
> If the server does not have permanent readdir cookies, then our client
> has never supported it anyway (nor will it ever do so). That whole
> 'cookieverf' READDIR bullshit has never provided a workable model for a
> POSIX client...


Thanks Trond for the explanation. Forgive my slowness. So you are
saying that with knfsd it's actually filesystem dependent and maybe
the reporters did not compare apples-to-apples and the difference is
in the behind file system.

Matt I'm sure Trond is right with regard to Ganesha, because we
send a readdir index and a cookieverf, which will change after
unlink. Since the application does not call opendir again the
client will send the old cookies, which is now a different file
or might get out-of-bounds for Ganesha.

Let me think about it a bit. I'm sure we can send a Better
64bit cookie, which will be more persistent, even across unlinks.

> 
> 


Thanks
Boaz

  reply	other threads:[~2012-03-26 18:44 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <209745840.4.1332606289405.JavaMail.root@thunderbeast.private.linuxbox.com>
2012-03-24 16:34 ` unlink within an open directory stream Matt W. Benjamin
2012-03-24 16:44   ` Myklebust, Trond
2012-03-24 16:53     ` Matt W. Benjamin
2012-03-24 17:12       ` Myklebust, Trond
2012-03-24 17:43         ` Matt W. Benjamin
2012-03-26 18:17         ` Boaz Harrosh
2012-03-26 18:25           ` Myklebust, Trond
2012-03-26 18:43             ` Boaz Harrosh [this message]
2012-03-26 18:55               ` Matt W. Benjamin
2012-03-26 19:01                 ` Myklebust, Trond
2012-03-26 19:07                 ` Boaz Harrosh
2012-03-30 15:24                 ` Peter Staubach
2012-03-30 15:46                   ` Myklebust, Trond
2012-03-30 16:46                     ` Peter Staubach
2012-03-30 17:10                     ` Matt W. Benjamin
2012-03-30 20:17           ` Jeff Layton
2012-04-04 15:35           ` Jeff Layton
2012-04-05  8:45             ` Benny Halevy
     [not found] <1598378492.82.1332790088063.JavaMail.root@thunderbeast.private.linuxbox.com>
2012-03-26 19:29 ` Matt W. Benjamin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F70B8DF.9000108@panasas.com \
    --to=bharrosh@panasas.com \
    --cc=Trond.Myklebust@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=matt@linuxbox.com \
    --cc=nfs-ganesha-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).