Linux NFS development
 help / color / mirror / Atom feed
From: Boaz Harrosh <bharrosh@panasas.com>
To: Trond Myklebust <Trond.Myklebust@netapp.com>,
	NFS list <linux-nfs@vger.kernel.org>,
	open-osd <osd-dev@open-osd.org>,
	Benny Halevy <bhalevy@tonian.com>
Subject: Re: [osd-dev] [PATCH] pnfs-obj: Remove unused variable from objlayout_get_deviceinfo()
Date: Fri, 30 Mar 2012 14:51:13 -0700	[thread overview]
Message-ID: <4F762AD1.2090306@panasas.com> (raw)
In-Reply-To: <4F7625D7.8070801@panasas.com>

On 03/30/2012 02:29 PM, Boaz Harrosh wrote:

> From: Sachin Bhamare <sbhamare@panasas.com>
> 
> Local variable 'sb' was not being used in objlayout_get_deviceinfo().
> 
> Signed-off-by: Sachin Bhamare <sbhamare@panasas.com>
> Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>


I was transitioning all my tree's to the 3.4-rc0 Kernel and noticed
we forgot this patch, Please add it to what ever next-kernel branch you
have.

Benny could you please make a pnfs-all-3.3 branch? It should be identical
to the 3.3-rc6, probably, but just for completeness.

Tell me if you also want to add the autologin patches to it I can help
out with that. Else the client side went into 3.4-rc0 so I'll send you
the exofs side for your future 3.4-rc1 tree.

Thanks
Boaz

> ---
>  fs/nfs/objlayout/objlayout.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/nfs/objlayout/objlayout.c b/fs/nfs/objlayout/objlayout.c
> index 1ae53eb..b158d1b 100644
> --- a/fs/nfs/objlayout/objlayout.c
> +++ b/fs/nfs/objlayout/objlayout.c
> @@ -604,7 +604,6 @@ int objlayout_get_deviceinfo(struct pnfs_layout_hdr *pnfslay,
>  {
>  	struct objlayout_deviceinfo *odi;
>  	struct pnfs_device pd;
> -	struct super_block *sb;
>  	struct page *page, **pages;
>  	u32 *p;
>  	int err;
> @@ -623,7 +622,6 @@ int objlayout_get_deviceinfo(struct pnfs_layout_hdr *pnfslay,
>  	pd.pglen = PAGE_SIZE;
>  	pd.mincount = 0;
>  
> -	sb = pnfslay->plh_inode->i_sb;
>  	err = nfs4_proc_getdeviceinfo(NFS_SERVER(pnfslay->plh_inode), &pd);
>  	dprintk("%s nfs_getdeviceinfo returned %d\n", __func__, err);
>  	if (err)



  reply	other threads:[~2012-03-30 21:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-30 21:29 [PATCH] pnfs-obj: Remove unused variable from objlayout_get_deviceinfo() Boaz Harrosh
2012-03-30 21:51 ` Boaz Harrosh [this message]
2012-04-03 13:45   ` [osd-dev] " Benny Halevy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F762AD1.2090306@panasas.com \
    --to=bharrosh@panasas.com \
    --cc=Trond.Myklebust@netapp.com \
    --cc=bhalevy@tonian.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=osd-dev@open-osd.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox