From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: linux-nfs-owner@vger.kernel.org Received: from relay.parallels.com ([195.214.232.42]:54128 "EHLO relay.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756726Ab2DKOmC convert rfc822-to-8bit (ORCPT ); Wed, 11 Apr 2012 10:42:02 -0400 Message-ID: <4F859823.4020902@parallels.com> Date: Wed, 11 Apr 2012 18:41:39 +0400 From: Stanislav Kinsbursky MIME-Version: 1.0 To: "J. Bruce Fields" CC: "linux-nfs@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devel@openvz.org" Subject: Re: [PATCH 4/8] nfsd: use exp_put() for svc_export_cache put References: <20120328150152.2646.33607.stgit@localhost6.localdomain6> <20120328150921.2646.46229.stgit@localhost6.localdomain6> <20120411141614.GB27751@fieldses.org> In-Reply-To: <20120411141614.GB27751@fieldses.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Sender: linux-nfs-owner@vger.kernel.org List-ID: 11.04.2012 18:16, J. Bruce Fields пишет: > On Wed, Mar 28, 2012 at 07:09:22PM +0400, Stanislav Kinsbursky wrote: >> This patch replaces cache_put() call for svc_export_cache by exp_put() call. > > Patch looks fine. Minor peeve: the changelog doesn't tell me anything I > couldn't figure out immediately from reading the patch. Tell me *why* > we're doing this ("Removing another hard-coded svc_export_cache will > simplify adding per-export caches later"), or if it's really totally > obvious I'd rather have an empty changelog than a useless one.... > Ok, will do so for further patches. -- Best regards, Stanislav Kinsbursky