From: Steve Dickson <SteveD@redhat.com>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH v5 1/9] nfsdcld: add client tracking daemon stub
Date: Mon, 16 Apr 2012 11:14:34 -0400 [thread overview]
Message-ID: <4F8C375A.7020200@RedHat.com> (raw)
In-Reply-To: <20120416102323.7f86eb56@corrin.poochiereds.net>
On 04/16/2012 10:23 AM, Jeff Layton wrote:
> On Mon, 16 Apr 2012 10:06:55 -0400
> Steve Dickson <SteveD@redhat.com> wrote:
>
>>
>>
>> On 02/01/2012 10:44 AM, Jeff Layton wrote:
>>> This program opens and "listens" on the new nfsd/cld rpc_pipefs pipe.
>>> The code here doesn't actually do anything on stable storage yet. That
>>> will be added in a later patch.
>>>
>>> The patch also adds a autoconf enable switch for the new daemon that
>>> defaults to "no", and a test for the upcall description header file.
>>>
>>> Signed-off-by: Jeff Layton <jlayton@redhat.com>
>>> ---
>>> configure.ac | 14 +++
>>> utils/Makefile.am | 4 +
>>> utils/nfsdcld/Makefile.am | 14 +++
>>> utils/nfsdcld/nfsdcld.c | 275 +++++++++++++++++++++++++++++++++++++++++++++
>>> 4 files changed, 307 insertions(+), 0 deletions(-)
>>> create mode 100644 utils/nfsdcld/Makefile.am
>>> create mode 100644 utils/nfsdcld/nfsdcld.c
>>>
>>> diff --git a/configure.ac b/configure.ac
>>> index 920e8da..d50e54e 100644
>>> --- a/configure.ac
>>> +++ b/configure.ac
>>> @@ -185,6 +185,12 @@ else
>>> AM_CONDITIONAL(MOUNT_CONFIG, [test "$enable_mount" = "yes"])
>>> fi
>>>
>>> +AC_ARG_ENABLE(nfsdcld,
>>> + [AC_HELP_STRING([--enable-nfsdcld],
>>> + [Create nfsdcld NFSv4 clientid tracking daemon. <:@default=no@:>@])],
>>> + enable_nfsdcld=$enableval,
>>> + enable_nfsdcld="no")
>>> +
>>> dnl Check for TI-RPC library and headers
>>> AC_LIBTIRPC
>>>
>>> @@ -260,6 +266,13 @@ if test "$enable_nfsv4" = yes; then
>>> dnl check for the keyutils libraries and headers
>>> AC_KEYUTILS
>>>
>>> + if test "$enable_nfsdcld" = "yes"; then
>>> + AC_CHECK_HEADERS([linux/nfsd/cld.h], ,
>>> + AC_MSG_ERROR([Cannot find header needed for nfsdcld]))
>>> + fi
>> This adds a dependency on the kernel headers being present which
>> is unprecedented for nfs-utils or any other package I'm aware of
>> and I just don't think its a good idea...
>>
>> So I'm wondering if there is someway around creating this
>> dependency...
>>
>
> The idea with that header was to have a common userspace/kernel header
> that describes the upcall/downcall format. The proper place for those
> is generally the kernel-headers package (at least on Fedora). Other
> distros have a similar package.
>
> One possibility is to include a copy of this header with nfs-utils, and
> only use it if /usr/include/linux/nfsd/cld.h isn't present. It's not
> ideal, but I suppose we could live with it if adding a dependency on
> kernel headers is anathema. It would take some rework of the code and
> autoconf/automake stuff however.
>
I believe this is how it was done in the past, keeping separate
header files... Since I'm causing the pain, I would be more than
willing to do the autoconf/automake updates...
steved.
next prev parent reply other threads:[~2012-04-16 15:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 15:44 [PATCH v5 0/9] nfsdcld: add a daemon to track NFSv4 client names on stable storage Jeff Layton
2012-02-01 15:44 ` [PATCH v5 1/9] nfsdcld: add client tracking daemon stub Jeff Layton
2012-04-16 14:06 ` Steve Dickson
2012-04-16 14:23 ` Jeff Layton
2012-04-16 15:14 ` Steve Dickson [this message]
2012-04-16 15:42 ` Jeff Layton
2012-04-16 16:44 ` Steve Dickson
2012-02-01 15:44 ` [PATCH v5 2/9] nfsdcld: add autoconf goop for sqlite Jeff Layton
2012-02-01 15:44 ` [PATCH v5 3/9] nfsdcld: add routines for a sqlite backend database Jeff Layton
2012-02-01 15:44 ` [PATCH v5 4/9] nfsdcld: add remove functionality Jeff Layton
2012-02-01 15:44 ` [PATCH v5 5/9] nfsdcld: add check/update functionality Jeff Layton
2012-02-01 15:44 ` [PATCH v5 6/9] nfsdcld: add function to remove unreclaimed client records Jeff Layton
2012-02-01 15:44 ` [PATCH v5 7/9] nfsdcld: make it watch for inotify events in the containing directory Jeff Layton
2012-02-01 15:44 ` [PATCH v5 8/9] nfsdcld: add a manpage for nfsdcld Jeff Layton
2012-02-01 15:44 ` [PATCH v5 9/9] nfsdcld: update the README Jeff Layton
2012-04-26 17:38 ` [PATCH v5 0/9] nfsdcld: add a daemon to track NFSv4 client names on stable storage Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8C375A.7020200@RedHat.com \
--to=steved@redhat.com \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).