From: Steve Dickson <SteveD@redhat.com>
To: Nick Alcock <nix@esperi.org.uk>
Cc: linux-nfs@vger.kernel.org, Nick Alcock <nick.alcock@oracle.com>
Subject: Re: [PATCH 3/4] No longer require NIS.
Date: Thu, 26 Apr 2012 16:07:07 -0400 [thread overview]
Message-ID: <4F99AAEB.6080509@RedHat.com> (raw)
In-Reply-To: <1328472138-25750-3-git-send-email-nix@esperi.org.uk>
On 02/05/2012 03:02 PM, Nick Alcock wrote:
> From: Nick Alcock <nick.alcock@oracle.com>
>
> NIS is deader than the proverbial dodo, and eglibc allows you to compile it out
> entirely. Though libtirpc can work with NIS, it works perfectly well if NIS
> is not in the libc, thanks to nsswitch (acting as if NIS is there but empty).
> However, when NIS is not compiled into eglibc, libnsl is not present. So
> check for it at configure time, and include it via LIBS if available.
> (I suspect this LIBS-inclusion will have no effect, and we don't even need
> to check for NIS at compile time, but I have no NIS-capable systems to
> test this on.)
>
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> ---
> configure.ac | 1 +
> src/Makefile.am | 2 +-
> 2 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 97c6f2c..7ff80a4 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -23,6 +23,7 @@ AC_HEADER_DIRENT
> AC_PREFIX_DEFAULT(/usr)
> AC_CHECK_HEADERS([arpa/inet.h fcntl.h libintl.h limits.h locale.h netdb.h netinet/in.h stddef.h stdint.h stdlib.h string.h sys/ioctl.h sys/param.h sys/socket.h sys/time.h syslog.h unistd.h])
> AC_CHECK_LIB([pthread], [pthread_create])
> +AC_CHECK_LIB([nsl], [yp_get_default_domain])
>
>
> AC_CONFIG_FILES([Makefile src/Makefile man/Makefile doc/Makefile])
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 509cf61..66350f5 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -40,7 +40,7 @@ lib_LTLIBRARIES = libtirpc.la
> # release number of your package. This is an abuse that only fosters
> # misunderstanding of the purpose of library versions."
> #
> -libtirpc_la_LDFLAGS = -lnsl -lpthread -version-info 1:10:0
> +libtirpc_la_LDFLAGS = -lpthread -version-info 1:10:0
>
> libtirpc_la_SOURCES = auth_none.c auth_unix.c authunix_prot.c bindresvport.c clnt_bcast.c \
> clnt_dg.c clnt_generic.c clnt_perror.c clnt_raw.c clnt_simple.c \
Committed...
steved.
next prev parent reply other threads:[~2012-04-26 20:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-05 20:02 [PATCH 1/4] Fix debugging reference from non-GSS to optional GSS code Nick Alcock
2012-02-05 20:02 ` [PATCH 2/4] Make svc_auth_none always available Nick Alcock
2012-04-26 20:06 ` Steve Dickson
2012-02-05 20:02 ` [PATCH 3/4] No longer require NIS Nick Alcock
2012-04-26 20:07 ` Steve Dickson [this message]
2012-02-05 20:02 ` [PATCH 4/4] Fix debugging-related namespace pollution Nick Alcock
2012-04-26 20:07 ` Steve Dickson
2012-04-26 20:06 ` [PATCH 1/4] Fix debugging reference from non-GSS to optional GSS code Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F99AAEB.6080509@RedHat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=nick.alcock@oracle.com \
--cc=nix@esperi.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).