Re: [PATCH 1/5] mountd: fix export upcall failure in use_ipaddr case.

[Steve Dickson <SteveD@redhat.com>]

On 05/02/2012 05:56 PM, J. Bruce Fields wrote:
> From: "J. Bruce Fields" <bfields@redhat.com>
> 
> After 0509d3428f523 "mountd: Replace "struct hostent" with "struct
> addinfo"", the export upcall fails in the use_ipaddr case.
> 
> I think we never noticed because a) the use_ipaddr case is rarer than
> the !use_ipaddr case, and b) the nfsd_fh upcall does a preemptive export
> downcall that renders the nfsd export call unnecessary in some cases.
> 
> Cc: Chuck Lever <chuck.lever@oracle.com>
> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
All 5 committed....

steved.

> ---
>  utils/mountd/cache.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/utils/mountd/cache.c b/utils/mountd/cache.c
> index ac9cdbd..cf07b56 100644
> --- a/utils/mountd/cache.c
> +++ b/utils/mountd/cache.c
> @@ -1064,6 +1064,7 @@ static void nfsd_export(FILE *f)
>  			goto out;
>  		ai = client_resolve(tmp->ai_addr);
>  		freeaddrinfo(tmp);
> +		if (!ai)
>  			goto out;
>  	}
>