From: Steve Dickson <SteveD@redhat.com>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfsdcld: demote pipe opening error to D_GENERAL
Date: Wed, 09 May 2012 14:14:53 -0400 [thread overview]
Message-ID: <4FAAB41D.70801@RedHat.com> (raw)
In-Reply-To: <1336508786-2531-1-git-send-email-jlayton@redhat.com>
On 05/08/2012 04:26 PM, Jeff Layton wrote:
> It's actually expected that this will fail initially when we start the
> daemon. Until knfsd has been started, the pipe doesn't exist, and we
> generally want to start nfsdcld before starting knfsd.
>
> Avoid the scary error message by demoting this message to D_GENERAL.
>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
Committed...
steved.
> ---
> utils/nfsdcld/nfsdcld.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/utils/nfsdcld/nfsdcld.c b/utils/nfsdcld/nfsdcld.c
> index f4e9502..e7af4e3 100644
> --- a/utils/nfsdcld/nfsdcld.c
> +++ b/utils/nfsdcld/nfsdcld.c
> @@ -138,7 +138,7 @@ cld_pipe_open(struct cld_client *clnt)
> xlog(D_GENERAL, "%s: opening upcall pipe %s", __func__, pipepath);
> fd = open(pipepath, O_RDWR, 0);
> if (fd < 0) {
> - xlog(L_ERROR, "%s: open of %s failed: %m", __func__, pipepath);
> + xlog(D_GENERAL, "%s: open of %s failed: %m", __func__, pipepath);
> return -errno;
> }
>
prev parent reply other threads:[~2012-05-09 18:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 20:26 [PATCH] nfsdcld: demote pipe opening error to D_GENERAL Jeff Layton
2012-05-09 18:14 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FAAB41D.70801@RedHat.com \
--to=steved@redhat.com \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).