Re: [PATCH] osd_login: fix DESTDIR install

[Boaz Harrosh <bharrosh@panasas.com>]

On 05/17/2012 08:24 AM, Mike Frysinger wrote:

> If the destination dir doesn't exist, the current install fails:
> make  install-data-hook
> make[4]: Entering directory `/var/tmp/portage/net-fs/nfs-utils-1.2.6/work/nfs-utils-1.2.6/utils/osd_login'
> /usr/bin/install -c --mode 755 osd_login /var/tmp/portage/net-fs/nfs-utils-1.2.6/image//sbin/osd_login
> /usr/bin/install: cannot create regular file ‘/var/tmp/portage/net-fs/nfs-utils-1.2.6/image//sbin/osd_login’: No such file or directory
> make[4]: *** [install-data-hook] Error 1
> 
> Rewrite the code to use automake's existing script support rather
> than trying to install the file by hand.
> 
> Reported-by: Branko BAdrljica <brankob@avtomatika.com>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>  utils/osd_login/Makefile.am |   11 +++++------
>  1 files changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/utils/osd_login/Makefile.am b/utils/osd_login/Makefile.am
> index adc493a..c85584c 100644
> --- a/utils/osd_login/Makefile.am
> +++ b/utils/osd_login/Makefile.am
> @@ -1,12 +1,11 @@
>  ## Process this file with automake to produce Makefile.in
>  
> -OSD_LOGIN_FILES= osd_login
> -
> -EXTRA_DIST= $(OSD_LOGIN_FILES)
> +# These scripts go in /sbin (not /usr/sbin), and that cannot be
> +# overriden at config time.
> +sbindir = /sbin
>  


On second thought, You know, I'm not sure about this fix.

A lot of times we install to a side folder, so we can later
tar and package the sub-folder without actually affecting
our live system. What will happen with the packagers that
are not RPM don't they rely on this?

I would like to let the user to install nfs-utils on the
side and to not conflict with the running system. Someone
how knows what he is doing can override the Kernel path
to what he wants. Just as he will need to override the
nfs init scripts.

So I would prefer if we can just create the $(DESTDIR)/sbin/


> -all-local: $(OSD_LOGIN_FILES)
> +OSD_LOGIN_FILES= osd_login
>  
> -install-data-hook:
> -	$(INSTALL) --mode 755 osd_login $(DESTDIR)/sbin/osd_login
> +sbin_SCRIPTS= osd_login
>  


But actually I do not understand these Makefiles. It might be
that it's what I want with the above "sbin_SCRIPTS="

>  MAINTAINERCLEANFILES = Makefile.in


Thanks
Boaz