From: Steve Dickson <SteveD@redhat.com>
To: NeilBrown <neilb@suse.de>
Cc: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: ANNOUNCE: nfs-utils-1.2.6 released.
Date: Thu, 17 May 2012 08:24:31 -0400 [thread overview]
Message-ID: <4FB4EDFF.3020809@RedHat.com> (raw)
In-Reply-To: <20120517164420.3fe761a5@notabene.brown>
Hey Neil,
On 05/17/2012 02:44 AM, NeilBrown wrote:
> On Mon, 14 May 2012 15:15:38 -0400 Steve Dickson <SteveD@redhat.com> wrote:
>
>> New Features in this release:
>> * The addition the nfsdcld daemon
>> * The addition of the osd_login script which is mandated by the
>> pnfs-objects standard
>
> Don't you hate it when people don't bother to test all your -rc's, then
> report bugs against your final release? Me too.
>
> mkdir /tmp/dest
> make DESTDIR=/tmp/dest install
I'll add this test to that makerel script you gave me way back when...
So hopefully I'll this type of breakage before I make a release!
>
> fails because it tries to install osd_login in /tmp/dest/sbin/osd_login
> without first creating /tmp/dest/sbin. All other required directories get
> created first.
>
> This patch - stealing an idea from utils/mount - seem to fix it.
Thanks for that patch... Its been applied with the correct spelling
of overridden! ;-)
steved.
>
> Thanks,
> NeilBrown
>
>
> commit 03bb227402ab023f4badb515022d49f82e01ff8d
> Author: Neil Brown <neilb@suse.de>
> Date: Thu May 17 16:40:40 2012 +1000
>
> osd_login - ensure /sbin is created before installation.
>
> If we use a more standard approach to describing the osd_login
> script, the automake infrastructure will create /sbin before
> attempting installation.
> This is important for: make DESTDIR=/empty-dir install
>
> Signed-off-by: NeilBrown <neilb@suse.de>
>
> diff --git a/utils/osd_login/Makefile.am b/utils/osd_login/Makefile.am
> index adc493a..d17ffa7 100644
> --- a/utils/osd_login/Makefile.am
> +++ b/utils/osd_login/Makefile.am
> @@ -1,12 +1,9 @@
> ## Process this file with automake to produce Makefile.in
>
> -OSD_LOGIN_FILES= osd_login
> +# These binaries go in /sbin (not /usr/sbin), and that cannot be
> +# overriden at config time.
> +sbindir = /sbin
>
> -EXTRA_DIST= $(OSD_LOGIN_FILES)
> -
> -all-local: $(OSD_LOGIN_FILES)
> -
> -install-data-hook:
> - $(INSTALL) --mode 755 osd_login $(DESTDIR)/sbin/osd_login
> +sbin_SCRIPTS = osd_login
>
> MAINTAINERCLEANFILES = Makefile.in
next prev parent reply other threads:[~2012-05-17 12:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 19:15 ANNOUNCE: nfs-utils-1.2.6 released Steve Dickson
2012-05-15 4:06 ` NeilBrown
2012-05-15 11:51 ` Steve Dickson
2012-05-15 12:20 ` Jim Rees
2012-05-15 14:19 ` Steve Dickson
2012-05-17 6:44 ` NeilBrown
2012-05-17 11:56 ` Jim Rees
2012-05-17 12:24 ` Steve Dickson [this message]
2012-05-17 17:18 ` Sachin Bhamare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB4EDFF.3020809@RedHat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).