From: Steve Dickson <SteveD@redhat.com>
To: Jim Rees <rees@umich.edu>
Cc: Mike Frysinger <vapier@gentoo.org>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] osd_login: fix DESTDIR install
Date: Thu, 17 May 2012 08:28:43 -0400 [thread overview]
Message-ID: <4FB4EEFB.7070102@RedHat.com> (raw)
In-Reply-To: <20120517115330.GA3733@umich.edu>
Hey Jim,
On 05/17/2012 07:53 AM, Jim Rees wrote:
> Mike Frysinger wrote:
>
> diff --git a/utils/osd_login/Makefile.am b/utils/osd_login/Makefile.am
> index adc493a..c85584c 100644
> --- a/utils/osd_login/Makefile.am
> +++ b/utils/osd_login/Makefile.am
> @@ -1,12 +1,11 @@
> ## Process this file with automake to produce Makefile.in
>
> -OSD_LOGIN_FILES= osd_login
> -
> -EXTRA_DIST= $(OSD_LOGIN_FILES)
> +# These scripts go in /sbin (not /usr/sbin), and that cannot be
> +# overriden at config time.
> +sbindir = /sbin
>
> You misspelled "overridden." Yes, I know you just copied this line from
> mount/Makefile.am, but there is no sense compounding the error.
Thanks for pointing out the misspelling in mount/Makefile.am... its
been corrected...
steved.
>
> Also it might be worth mentioning in the comment why we have this
> restriction.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-05-17 12:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-17 5:24 [PATCH] osd_login: fix DESTDIR install Mike Frysinger
2012-05-17 11:53 ` Jim Rees
2012-05-17 12:07 ` Boaz Harrosh
2012-05-17 12:28 ` Steve Dickson [this message]
2012-05-17 12:19 ` Boaz Harrosh
2012-05-17 13:09 ` Jim Rees
2012-05-17 13:42 ` Boaz Harrosh
2012-05-17 16:08 ` Mike Frysinger
2012-05-17 12:27 ` Steve Dickson
2012-05-17 12:42 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB4EEFB.7070102@RedHat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=rees@umich.edu \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).