From: Boaz Harrosh <bharrosh@panasas.com>
To: Jim Rees <rees@umich.edu>
Cc: Mike Frysinger <vapier@gentoo.org>, <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] osd_login: fix DESTDIR install
Date: Thu, 17 May 2012 16:42:08 +0300 [thread overview]
Message-ID: <4FB50030.1010501@panasas.com> (raw)
In-Reply-To: <20120517130925.GA10380@umich.edu>
On 05/17/2012 04:09 PM, Jim Rees wrote:
> Boaz Harrosh wrote:
>
> On second thought, You know, I'm not sure about this fix.
>
> A lot of times we install to a side folder, so we can later
> tar and package the sub-folder without actually affecting
> our live system. What will happen with the packagers that
> are not RPM don't they rely on this?
>
> I would like to let the user to install nfs-utils on the
> side and to not conflict with the running system. Someone
> how knows what he is doing can override the Kernel path
> to what he wants. Just as he will need to override the
> nfs init scripts.
>
> So I would prefer if we can just create the $(DESTDIR)/sbin/
>
> I think the makefiles already create $(DESTDIR)$(sbindir). The problem was
> that you weren't using $(DESTDIR)$(sbindir), you were using
> $(DESTDIR)/sbin. The patch sets $(sbindir) to /sbin, so everything should
> just work.
>
> But I could be wrong, automake is a black box to me.
Make sense thanks. Just wanted to make sure.
Boaz
next prev parent reply other threads:[~2012-05-17 13:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-17 5:24 [PATCH] osd_login: fix DESTDIR install Mike Frysinger
2012-05-17 11:53 ` Jim Rees
2012-05-17 12:07 ` Boaz Harrosh
2012-05-17 12:28 ` Steve Dickson
2012-05-17 12:19 ` Boaz Harrosh
2012-05-17 13:09 ` Jim Rees
2012-05-17 13:42 ` Boaz Harrosh [this message]
2012-05-17 16:08 ` Mike Frysinger
2012-05-17 12:27 ` Steve Dickson
2012-05-17 12:42 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB50030.1010501@panasas.com \
--to=bharrosh@panasas.com \
--cc=linux-nfs@vger.kernel.org \
--cc=rees@umich.edu \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).