From: Boaz Harrosh <bharrosh@panasas.com>
To: "Adamson, Andy" <William.Adamson@netapp.com>
Cc: Benny Halevy <bhalevy@tonian.com>,
Andy Adamson <androsadamson@gmail.com>,
"Myklebust, Trond" <Trond.Myklebust@netapp.com>,
"<linux-nfs@vger.kernel.org>" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 2/3] NFSv4.1 mark layout when already returned
Date: Mon, 11 Jun 2012 19:07:51 +0300 [thread overview]
Message-ID: <4FD617D7.7030209@panasas.com> (raw)
In-Reply-To: <4F7E0716-F1A2-48E0-BC18-E91B33FBA5C2@netapp.com>
On 06/11/2012 06:52 PM, Adamson, Andy wrote:
<>
>>
>> Yeah, right now pnfs_return_layout always returns the whole layout
>> so this patch works. Boaz's point (I think) was that marking the whole layout
>> as returned in the generic layer will prevent returning of layout segments
>> by the objects layout.
>
> Yep. I agree that _pnfs_return_layout needs to operate on an input range, and
> should wait for all lseg references - the "normal" behavior.
>
You mean the normal "error handling behavior" right?
> Then, after that is done,
> I will write a patch to allow the file layout driver to call _pnfs_return_layout in
> "fence mode" e.g returning the whole layout, and not waiting for the last lseg reference.
>
This one I do not understand. And am really trying. please be slow with me?
1. What does it means "whole layout" Is that just a short hand for
"all segments" ?
2. What is "fence mode" LAYOUTRETURN. where did you take this one from?
3. How does "fence mode" permits a client to use a layout segment after
the send of LAYOUTRETURN. Since that is what we do (to date) because
of race.
Thanks
Boaz
> -->Andy
next prev parent reply other threads:[~2012-06-11 16:08 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-01 17:19 [PATCH 1/3] NFSv4.1 do not call LAYOUTRETURN when there are no legs andros
2012-06-01 17:19 ` [PATCH 2/3] NFSv4.1 mark layout when already returned andros
2012-06-02 22:51 ` Boaz Harrosh
2012-06-05 13:36 ` Adamson, Andy
2012-06-05 13:47 ` Andy Adamson
2012-06-05 14:54 ` Boaz Harrosh
2012-06-05 19:22 ` Andy Adamson
2012-06-05 20:49 ` Boaz Harrosh
2012-06-11 9:56 ` Benny Halevy
2012-06-11 10:44 ` Boaz Harrosh
2012-06-11 14:04 ` Benny Halevy
2012-06-11 14:21 ` Adamson, Andy
2012-06-11 14:51 ` Boaz Harrosh
2012-06-11 15:41 ` Adamson, Andy
2012-06-11 16:14 ` Boaz Harrosh
2012-06-11 15:08 ` Adamson, Andy
2012-06-11 15:38 ` Benny Halevy
2012-06-11 15:52 ` Adamson, Andy
2012-06-11 16:07 ` Boaz Harrosh [this message]
2012-06-11 15:59 ` Boaz Harrosh
2012-06-01 17:19 ` [PATCH 3/3] NFSv4.1 fence all layouts with file layout data server connection errors andros
2012-06-02 22:33 ` Boaz Harrosh
2012-06-04 13:49 ` Adamson, Andy
2012-06-02 23:00 ` [PATCH 1/3] NFSv4.1 do not call LAYOUTRETURN when there are no legs Boaz Harrosh
2012-06-05 13:36 ` Adamson, Andy
2012-06-05 15:01 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD617D7.7030209@panasas.com \
--to=bharrosh@panasas.com \
--cc=Trond.Myklebust@netapp.com \
--cc=William.Adamson@netapp.com \
--cc=androsadamson@gmail.com \
--cc=bhalevy@tonian.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).