From: Boaz Harrosh <bharrosh@panasas.com>
To: "Adamson, Andy" <William.Adamson@netapp.com>
Cc: Benny Halevy <bhalevy@tonian.com>,
"Welch, Brent" <welch@panasas.com>,
"Bhamare, Sachin" <sbhamare@panasas.com>,
Andy Adamson <androsadamson@gmail.com>,
"Myklebust, Trond" <Trond.Myklebust@netapp.com>,
"<linux-nfs@vger.kernel.org>" <linux-nfs@vger.kernel.org>,
"Huang, James" <jhuang@panasas.com>
Subject: Re: [PATCH 2/3] NFSv4.1 mark layout when already returned
Date: Mon, 11 Jun 2012 19:14:15 +0300 [thread overview]
Message-ID: <4FD61957.1070900@panasas.com> (raw)
In-Reply-To: <005343AE-888D-4CE1-A928-685252AE9C84@netapp.com>
On 06/11/2012 06:41 PM, Adamson, Andy wrote:
> On Jun 11, 2012, at 10:51 AM, Boaz Harrosh wrote:
>> I'm not sure I understood what you meant.
>>
>> In the "normal behavior" we don't send a LAYOUTRETURN at all
>> in the forgetful model. Which proved beneficiary in the light
>> of concurrent GETs vs RETURNs.
>>
>> I thought we are only taking about the error case. Do you
>> mean there is a 3rd case? please explain.
>
> The normal case of calling LAYOUTRETURN on evict inode.
>
evict LAYOUTRETURN is mute because evict() means inode has no more
references, which specifically means no more layout_segments which
hold a reference on the inode.
The interesting part is the error-handling case, on one of the
layout_segments. What are we aloud to do after we send the
LAYOUTRETURN to MDS.
It's what I'm talking about, and is a part of of the general
error-reporting in 4.2 to come.
Boaz
> -->Andy
>
>>
>> Thanks
>> Boaz
>
next prev parent reply other threads:[~2012-06-11 16:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-01 17:19 [PATCH 1/3] NFSv4.1 do not call LAYOUTRETURN when there are no legs andros
2012-06-01 17:19 ` [PATCH 2/3] NFSv4.1 mark layout when already returned andros
2012-06-02 22:51 ` Boaz Harrosh
2012-06-05 13:36 ` Adamson, Andy
2012-06-05 13:47 ` Andy Adamson
2012-06-05 14:54 ` Boaz Harrosh
2012-06-05 19:22 ` Andy Adamson
2012-06-05 20:49 ` Boaz Harrosh
2012-06-11 9:56 ` Benny Halevy
2012-06-11 10:44 ` Boaz Harrosh
2012-06-11 14:04 ` Benny Halevy
2012-06-11 14:21 ` Adamson, Andy
2012-06-11 14:51 ` Boaz Harrosh
2012-06-11 15:41 ` Adamson, Andy
2012-06-11 16:14 ` Boaz Harrosh [this message]
2012-06-11 15:08 ` Adamson, Andy
2012-06-11 15:38 ` Benny Halevy
2012-06-11 15:52 ` Adamson, Andy
2012-06-11 16:07 ` Boaz Harrosh
2012-06-11 15:59 ` Boaz Harrosh
2012-06-01 17:19 ` [PATCH 3/3] NFSv4.1 fence all layouts with file layout data server connection errors andros
2012-06-02 22:33 ` Boaz Harrosh
2012-06-04 13:49 ` Adamson, Andy
2012-06-02 23:00 ` [PATCH 1/3] NFSv4.1 do not call LAYOUTRETURN when there are no legs Boaz Harrosh
2012-06-05 13:36 ` Adamson, Andy
2012-06-05 15:01 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD61957.1070900@panasas.com \
--to=bharrosh@panasas.com \
--cc=Trond.Myklebust@netapp.com \
--cc=William.Adamson@netapp.com \
--cc=androsadamson@gmail.com \
--cc=bhalevy@tonian.com \
--cc=jhuang@panasas.com \
--cc=linux-nfs@vger.kernel.org \
--cc=sbhamare@panasas.com \
--cc=welch@panasas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).