Linux NFS development
 help / color / mirror / Atom feed
From: Bryan Schumaker <bjschuma@netapp.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: rpcauth_create() returns ERR_PTR
Date: Mon, 25 Jun 2012 16:48:12 -0400	[thread overview]
Message-ID: <4FE8CE8C.7020007@netapp.com> (raw)
In-Reply-To: <17B0469E-0417-4F74-A035-625D41E5609B@oracle.com>

On 06/25/2012 04:43 PM, Chuck Lever wrote:
> Hi-
> 
> nfs4_create_sec_client() and nfs4_lookup_root_sec() both invoke rpcauth_create().  They check to see that it returned something that wasn't NULL.
> 
> As far as I can tell, rpcauth_create() reports an error by returning something that IS_ERR.  It doesn't return NULL.  nfs_init_server_rpcclient() appears to be correct.
> 
> The fix looks simple, but since I don't have any unit tests for this area of code, I was hoping you could take it from here.
> 

Sure, I'll take a look at it.  You're right, checking for an error code instead of NULL sounds like an easy fix.

- Bryan


  reply	other threads:[~2012-06-25 20:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-25 20:43 rpcauth_create() returns ERR_PTR Chuck Lever
2012-06-25 20:48 ` Bryan Schumaker [this message]
2012-06-25 21:56   ` Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FE8CE8C.7020007@netapp.com \
    --to=bjschuma@netapp.com \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox