From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74B8A2D0601 for ; Wed, 22 Oct 2025 06:57:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761116223; cv=none; b=bP7sWGzpx1XjN9CVeYFQliHHtUwNJofntQL/sf43FGue/LCxhTiQ/r+qosFvSkApmI/LnYrqbxdkR8VpnjcZtpWoVvEIUwZXD4k8WjA+dK3kqfCCUKIvszLJI+IPOyFmx1Q2qTdGqI3KytxrJ2Lg94S8OOXFTeBZowwdAYuKPqY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761116223; c=relaxed/simple; bh=WBEULDsMmUTL94Xw0iQEoIsxKU2u4+yiggkBAlUOqOE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dCbB9mjat7N3zonk7c+QRM2L8rnaACZJX9CnVYMob7WtvSURbvLX4dvVFNPmLrNGKt8BGbFMe5cwGENn8dutHoK6lfRCFp611sZuhluBri1j2VR7HoZ52/Vw+4NwBGLWprSS7sEjzcOIHabCuEUwXB7sNLrAbibTKcodx+7xe24= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=Hm85UpzW; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=2TBdz6Nv; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=MlixlT1K; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=4Jp/cJAb; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Hm85UpzW"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="2TBdz6Nv"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="MlixlT1K"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="4Jp/cJAb" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A5ED11F38D; Wed, 22 Oct 2025 06:56:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1761116214; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Rx8DJYuxgTbtWD3EG43xudBz/lgkdwbOWUShBy3f9Jc=; b=Hm85UpzWcum4e7txV0UEEFJ29U/jlHgtQ4qH6RuCV7kLNTJYIA+EGW0j2JsnMPMwERZ+Wl puRK81INf5XX0jKtSeIDrXAD8UlMpTGi8Fy3TtoZ2RPkOx5IPEhRV5C3f2rax9FUL+dZzu +wIVEOo1E5wg7ZI+YU0Layjh0aD4LmI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1761116214; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Rx8DJYuxgTbtWD3EG43xudBz/lgkdwbOWUShBy3f9Jc=; b=2TBdz6NviOX+2CBmad8Y4BSxo+23Z259FmCmu4SjFfLwbqJZvE0S2FtSQ6Z8TY9hZpz7l5 wWBef15x0fh/rOAg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=MlixlT1K; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="4Jp/cJAb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1761116210; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Rx8DJYuxgTbtWD3EG43xudBz/lgkdwbOWUShBy3f9Jc=; b=MlixlT1K5vWDod5mnzmjrqH+zeoRq9vUCRLedWmAH0n67PWykXMi7akbK6/mg5piPZeDHt ss425rLTZoaCh65HOpLS2yTME3Q3xa/P814heROGqUll+WdZSfnDRY3CgPhN4W7wBq5LIV izCqyDjhPyPES/qmxuIYZRPS7w/Q7Ec= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1761116210; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Rx8DJYuxgTbtWD3EG43xudBz/lgkdwbOWUShBy3f9Jc=; b=4Jp/cJAbhag3/g8ao1mWaHUrIxz65ak2h7nqE/i/yKW47JTRuHLyCw2JKrgS4w0/BwpodA sfLPLNMexXtGn+Bg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B020713A29; Wed, 22 Oct 2025 06:56:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id wfoeKDGA+GhVdQAAD6G6ig (envelope-from ); Wed, 22 Oct 2025 06:56:49 +0000 Message-ID: <4b2e5998-a646-4f99-8c87-95975ff8fe66@suse.de> Date: Wed, 22 Oct 2025 08:56:41 +0200 Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 5/7] nvme-tcp: Support KeyUpdate To: Alistair Francis Cc: chuck.lever@oracle.com, hare@kernel.org, kernel-tls-handshake@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-nvme@lists.infradead.org, linux-nfs@vger.kernel.org, kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, kch@nvidia.com, Alistair Francis References: <20251017042312.1271322-1-alistair.francis@wdc.com> <20251017042312.1271322-6-alistair.francis@wdc.com> Content-Language: en-US From: Hannes Reinecke In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: A5ED11F38D X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; URIBL_BLOCKED(0.00)[wdc.com:email,suse.de:email,suse.de:mid,suse.de:dkim,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWELVE(0.00)[15]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FREEMAIL_TO(0.00)[gmail.com]; ARC_NA(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:mid,suse.de:dkim,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns] X-Rspamd-Action: no action X-Spam-Flag: NO X-Spam-Score: -4.51 X-Spam-Level: On 10/22/25 06:35, Alistair Francis wrote: > On Mon, Oct 20, 2025 at 4:22 PM Hannes Reinecke wrote: >> >> On 10/17/25 06:23, alistair23@gmail.com wrote: >>> From: Alistair Francis >>> [ .. ]>>> @@ -1723,6 +1763,7 @@ static void nvme_tcp_tls_done(void *data, int status, key_serial_t pskid, >>> ctrl->ctrl.tls_pskid = key_serial(tls_key); >>> key_put(tls_key); >>> queue->tls_err = 0; >>> + queue->user_session_id = user_session_id; >> >> Hmm. I wonder, do we need to store the generation number somewhere? >> Currently the sysfs interface is completely oblivious that a key update >> has happened. I really would like to have _some_ indicator there telling >> us that a key update had happened, and the generation number would be >> ideal here. > > I don't follow. > > The TLS layer will report the number of KeyUpdates that have been > received. Userspace also knows that a KeyUpdate happened as we call to > userspace to handle updating the keys. > Oh, the tlshd will know that (somehow). But everyone else will not; the 'tls_pskid' contents will stay the the same. Can we have a sysfs attribute reporting the sequence number of the most recent KeyUpdate? Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich