From: Benjamin Coddington <bcodding@redhat.com>
To: Trond Myklebust <trond.myklebust@primarydata.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
Jeff Layton <jlayton@poochiereds.net>,
"J. Bruce Fields" <bfields@fieldses.org>,
Christoph Hellwig <hch@infradead.org>
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH v4 01/10] NFS4: remove a redundant lock range check
Date: Wed, 30 Dec 2015 08:13:57 -0500 [thread overview]
Message-ID: <4b51943c8d3802ece5b99125a971759f77a57270.1451480826.git.bcodding@redhat.com> (raw)
In-Reply-To: <cover.1451480826.git.bcodding@redhat.com>
In-Reply-To: <cover.1451480826.git.bcodding@redhat.com>
flock64_to_posix_lock() is already doing this check
Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
Reviewed-by: Jeff Layton <jeff.layton@primarydata.com>
---
fs/nfs/nfs4proc.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 8981803..2231d7d 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -6108,9 +6108,6 @@ nfs4_proc_lock(struct file *filp, int cmd, struct file_lock *request)
ctx = nfs_file_open_context(filp);
state = ctx->state;
- if (request->fl_start < 0 || request->fl_end < 0)
- return -EINVAL;
-
if (IS_GETLK(cmd)) {
if (state != NULL)
return nfs4_proc_getlk(state, F_GETLK, request);
--
1.7.1
next prev parent reply other threads:[~2015-12-30 13:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-30 13:13 [PATCH v4 00/10] locking fixups for NFS Benjamin Coddington
2015-12-30 13:13 ` Benjamin Coddington [this message]
2016-01-03 12:00 ` [PATCH v4 01/10] NFS4: remove a redundant lock range check Christoph Hellwig
2015-12-30 13:13 ` [PATCH v4 02/10] NFS: Move the flock open mode check into nfs_flock() Benjamin Coddington
2016-01-03 12:01 ` Christoph Hellwig
2015-12-30 13:13 ` [PATCH v4 03/10] NFS: Pass nfs_open_context instead of file to the lock procs Benjamin Coddington
2016-01-03 12:02 ` Christoph Hellwig
2015-12-30 13:14 ` [PATCH v4 04/10] NFSv4: Pass nfs_open_context instead of nfs4_state to nfs4_proc_unlck() Benjamin Coddington
2016-01-03 12:02 ` Christoph Hellwig
2015-12-30 13:14 ` [PATCH v4 05/10] lockd: Plumb nfs_open_context into nlm client unlock Benjamin Coddington
2016-01-03 12:03 ` Christoph Hellwig
2015-12-30 13:14 ` [PATCH v4 06/10] lockd: Send the inode to nlmclnt_setlockargs() Benjamin Coddington
2016-01-03 12:04 ` Christoph Hellwig
2015-12-30 13:14 ` [PATCH v4 07/10] lockd: do_vfs_lock() only needs the inode Benjamin Coddington
2016-01-03 12:04 ` Christoph Hellwig
2015-12-30 13:14 ` [PATCH v4 08/10] locks: Set FL_CLOSE when removing flock locks on close() Benjamin Coddington
2016-01-03 12:05 ` Christoph Hellwig
2015-12-30 13:14 ` [PATCH v4 09/10] NFS: Deferred unlocks - always unlock on FL_CLOSE Benjamin Coddington
2016-01-05 3:30 ` Trond Myklebust
2016-01-05 13:48 ` Benjamin Coddington
2015-12-30 13:14 ` [PATCH v4 10/10] NFS: cleanup do_vfs_lock() Benjamin Coddington
2016-01-03 12:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b51943c8d3802ece5b99125a971759f77a57270.1451480826.git.bcodding@redhat.com \
--to=bcodding@redhat.com \
--cc=anna.schumaker@netapp.com \
--cc=bfields@fieldses.org \
--cc=hch@infradead.org \
--cc=jlayton@poochiereds.net \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).