From: Steve Dickson <steved@redhat.com>
To: Anna Schumaker <anna@kernel.org>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2 1/2] rpcctl: Use the correct function for setting xprts offline and online
Date: Thu, 26 May 2022 13:34:06 -0400 [thread overview]
Message-ID: <4deae036-d3a7-abc5-446c-8f102c7da455@redhat.com> (raw)
In-Reply-To: <20220519154727.3577715-1-anna@kernel.org>
On 5/19/22 11:47 AM, Anna Schumaker wrote:
> From: Anna Schumaker <Anna.Schumaker@Netapp.com>
>
> Otherwise the tool will tell us:
> 'Namespace' object has no attribute 'set_state'
>
> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Committed... (tag: nfs-utils-2-6-2-rc5)
steved.
> ---
> tools/rpcctl/rpcctl.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/rpcctl/rpcctl.py b/tools/rpcctl/rpcctl.py
> index b8df556b682c..2a69eacd3103 100755
> --- a/tools/rpcctl/rpcctl.py
> +++ b/tools/rpcctl/rpcctl.py
> @@ -142,7 +142,7 @@ class Xprt:
> xprt.set_state("offline")
> xprt.set_state("remove")
> else:
> - args.set_state(args.property)
> + xprt.set_state(args.property)
> print(xprt)
>
>
prev parent reply other threads:[~2022-05-26 17:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 15:47 [PATCH v2 1/2] rpcctl: Use the correct function for setting xprts offline and online Anna Schumaker
2022-05-19 15:47 ` [PATCH v2 2/2] rpcctl: Print a message if the user tries to modify a main xprt Anna Schumaker
2022-05-26 17:34 ` Steve Dickson
2022-05-26 17:34 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4deae036-d3a7-abc5-446c-8f102c7da455@redhat.com \
--to=steved@redhat.com \
--cc=anna@kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).