Linux NFS development
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: Amir Goldstein <amir73il@gmail.com>,
	Christian Brauner <brauner@kernel.org>
Cc: Chuck Lever <chuck.lever@oracle.com>,
	Christoph Hellwig <hch@lst.de>,  Neil Brown <neil@brown.name>,
	Jan Kara <jack@suse.cz>,
	linux-fsdevel@vger.kernel.org, 	linux-nfs@vger.kernel.org
Subject: Re: [PATCH v3 0/2] nfsd and special kernel filesystems
Date: Wed, 28 Jan 2026 06:30:48 -0500	[thread overview]
Message-ID: <4ebd0e6d9c91d1851d284ea02f9663a928a18888.camel@kernel.org> (raw)
In-Reply-To: <20260128111645.902932-1-amir73il@gmail.com>

On Wed, 2026-01-28 at 12:16 +0100, Amir Goldstein wrote:
> Christian,
> 
> I noticed that the kernel-doc refactoring queued on vfs-7.0.misc was
> going to conflict with v2 [1], so I rebased over vfs-7.0.misc and split
> it into doc update and nfsd fix patch that could be backported.
> 
> RVBs by Chuck and Jeff were removed due to the slight changes in wording.
> 
> I'd like to acknowledge that Christoph wrote on v2 that:
> "As last time I'd be happy to help write documentation, but even
>  after looking at the methods, their documentations and the commits
>  adding them I do not understand them.  So getting an explanation
>  from Christian would be really helpful to move forward here."
> 
> IMO, further clarifications of the new methods is very much welcome,
> but should not be blocking the merge of this patch set, which at least
> clarifies the WHAT (to use them for) if not the HOW (to use them).
> 
> Thanks,
> Amir.
> 
> Changes since v2:
> - Rebase over vfs-7.0.misc
> - Split to doc/fix patches
> - Remove RVBs
> 
> [1] https://lore.kernel.org/linux-fsdevel/20260122141942.660948-1-amir73il@gmail.com/
> 
> Amir Goldstein (2):
>   exportfs: clarify the documentation of open()/permission() expotrfs
>     ops
>   nfsd: do not allow exporting of special kernel filesystems
> 
>  fs/nfsd/export.c         |  8 +++++---
>  include/linux/exportfs.h | 25 ++++++++++++++++++++++---
>  2 files changed, 27 insertions(+), 6 deletions(-)

Updated version seems reasonable:

Reviewed-by: Jeff Layton <jlayton@kernel.org>

      parent reply	other threads:[~2026-01-28 11:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-28 11:16 [PATCH v3 0/2] nfsd and special kernel filesystems Amir Goldstein
2026-01-28 11:16 ` [PATCH v3 1/2] exportfs: clarify the documentation of open()/permission() expotrfs ops Amir Goldstein
2026-01-28 16:09   ` Chuck Lever
2026-01-28 19:27     ` Amir Goldstein
2026-01-28 11:16 ` [PATCH v3 2/2] nfsd: do not allow exporting of special kernel filesystems Amir Goldstein
2026-01-28 16:11   ` Chuck Lever
2026-01-28 19:28     ` Amir Goldstein
2026-01-28 11:30 ` Jeff Layton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ebd0e6d9c91d1851d284ea02f9663a928a18888.camel@kernel.org \
    --to=jlayton@kernel.org \
    --cc=amir73il@gmail.com \
    --cc=brauner@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neil@brown.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox