Re: [PATCH v1 00/27] Convert server-side NFSv2 XDR to use xdrgen

[Jeff Layton <jlayton@kernel.org>]

On Wed, 2026-09-16 at 12:28 -0400, Chuck Lever wrote:
> Replace NFSD's NFSv2 XDR encoders and decoders with code that is
> mechanically generated directly from the NFSv2 RPC language
> specification.
> 
> The benefits for NFSv2 are marginal. When we eventually convert
> newer NFS versions to use xdrgen, I expect a reduction in human
> coding errors, improved spec compliance, and better memory safety
> for those more complex NFS programs.
> 
> These patches have been lightly tested with fstests run against an
> xfs export.
> 
> Chuck Lever (27):
>   Documentation: Add the RPC language description of NFSv2
>   NFSD: Add infrastructure for generating NFSv2 XDR encoders and
>     decoders
>   NFSD: Use xdrgen-generated NFSv2 protocol definitions
>   NFSD: Remove '#include "xdr.h"' from fs/nfsd/xdr3.h
>   NFSD: Relocate the NFSv2 XDR storage union into nfsproc.c
>   NFSD: Use xdrgen XDR functions for the NFSv2 NULL procedure
>   NFSD: Use xdrgen XDR functions for NFSv2 GETATTR procedure
>   NFSD: Use xdrgen XDR functions for NFSv2 SETATTR procedure
>   NFSD: Use xdrgen XDR functions for the NFSv2 ROOT procedure
>   NFSD: Use xdrgen XDR functions for the NFSv2 LOOKUP procedure
>   NFSD: Use xdrgen XDR functions for NFSv2 READLINK procedure
>   NFSD: Use xdrgen XDR functions for NFSv2 READ procedure
>   NFSD: Use xdrgen XDR functions for the NFSv2 WRITECACHE procedure
>   NFSD: Use xdrgen XDR functions for NFSv2 WRITE procedure
>   NFSD: Refactor nfsd_proc_create()
>   NFSD: Use xdrgen XDR functions for NFSv2 CREATE procedure
>   NFSD: Use xdrgen XDR functions for the NFSv2 REMOVE procedure
>   NFSD: Use xdrgen XDR functions for the NFSv2 RENAME procedure
>   NFSD: Use xdrgen XDR functions for the NFSv2 LINK procedure
>   NFSD: Use xdrgen XDR functions for NFSv2 SYMLINK procedure
>   NFSD: Use xdrgen XDR functions for NFSv2 MKDIR procedure
>   NFSD: Use xdrgen XDR functions for NFSv2 RMDIR procedure
>   NFSD: Use xdrgen XDR functions for the NFSv2 STATFS procedure
>   NFSD: Use xdrgen XDR functions for NFSv2 READDIR arguments
>   NFSD: Add a streaming directory reader
>   NFSD: Refactor NFSv2 directory cookie encoding
>   NFSD: Use xdrgen XDR functions for NFSv2 READDIR results
> 
>  Documentation/sunrpc/xdr/nfs2.x    |  254 +++++
>  fs/nfs_common/common.c             |    5 +-
>  fs/nfsd/Makefile                   |   15 +-
>  fs/nfsd/nfs2acl.c                  |    2 +-
>  fs/nfsd/nfs2xdr_gen.c              | 1079 +++++++++++++++++++
>  fs/nfsd/nfs2xdr_gen.h              |   46 +
>  fs/nfsd/nfs3xdr.c                  |    2 +
>  fs/nfsd/nfsd.h                     |    2 -
>  fs/nfsd/nfserr.h                   |    2 +-
>  fs/nfsd/nfsfh.h                    |    5 +
>  fs/nfsd/nfsproc.c                  | 1574 +++++++++++++++++++---------
>  fs/nfsd/nfsxdr.c                   |  605 +++--------
>  fs/nfsd/vfs.c                      |  239 +++--
>  fs/nfsd/vfs.h                      |   40 +
>  fs/nfsd/xdr.h                      |  167 +--
>  fs/nfsd/xdr3.h                     |    3 +-
>  include/linux/nfs_common.h         |    4 +-
>  include/linux/sunrpc/xdrgen/nfs2.h |  298 ++++++
>  18 files changed, 3121 insertions(+), 1221 deletions(-)
>  create mode 100644 Documentation/sunrpc/xdr/nfs2.x
>  create mode 100644 fs/nfsd/nfs2xdr_gen.c
>  create mode 100644 fs/nfsd/nfs2xdr_gen.h
>  create mode 100644 include/linux/sunrpc/xdrgen/nfs2.h

This all looks like a fairly sane and straightforward conversion, but
it's too much to review in detail. It's almost a shame to do this at a
time when we're talking about deprecating v2, but if it makes ongoing
maintenance easier, then I'm on board.

Also, there are 2 patches that were sent as part of this series, but
seem to be a separate series:

[PATCH v1 1/2] NFSD: map fh_verify() status codes for NFS_ACLv2 replies
[PATCH v1 2/2] NFSD: map fh_verify() status codes for NFS_ACLv3 replies

Did you mean to send those separately? In any case, for the 27-patch
series:

Acked-by: Jeff Layton <jlayton@kernel.org>