linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bryan Schumaker <bjschuma@netapp.com>
To: William Dauchy <wdauchy@gmail.com>
Cc: Trond.Myklebust@netapp.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/3] NFS: Clear key construction data if the idmap upcall fails
Date: Thu, 16 Aug 2012 11:21:23 -0400	[thread overview]
Message-ID: <502D0FF3.8010302@netapp.com> (raw)
In-Reply-To: <CAJ75kXbdvKiGt9bYvD1Wu-b6ZkVS0yG2YdkkuS7O+r_-+ynPWQ@mail.gmail.com>

On 08/16/2012 11:07 AM, William Dauchy wrote:
> On Thu, Aug 16, 2012 at 3:45 PM, William Dauchy <wdauchy@gmail.com> wrote:
>> On another setup, this patch is breaking the legacy mapping.
>> rpc.idmapd is running but it can't map any user. I'm trying to see the
>> difference with the previous test I made.
> 
> my second test is on 64 bits (the previous was on 32 bits).
> I'm also getting many errors from the userland:
> rpc.idmapd: nfscb: write(/var/lib/nfs/rpc_pipefs/nfs/clnt4/idmap): No
> space left on device
> 
> I assume this is because of adding `im_private` in `struct idmap_msg`
> since removing the field resolves the issue.
> I tried to find a wrong sizeof regarding `struct idmap_msg` but didn’t
> found any thing at the moment.
> 

I was afraid im_private would cause problems, but I wouldn't expect "No space left on device".  You did double check the output of `df`, right? :).

I'll play around with it soon to see what I can find.  Thanks for finding this!

- Bryan


  reply	other threads:[~2012-08-16 15:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-09 18:05 [PATCH 1/3] NFS: Clear key construction data if the idmap upcall fails bjschuma
2012-08-09 18:05 ` [PATCH 2/3] NFS: return -ENOKEY when the upcall fails to map the name bjschuma
2012-08-10 10:10   ` William Dauchy
2012-08-10 11:04   ` William Dauchy
2012-08-09 18:05 ` [PATCH 3/3] NFS: Use kzalloc() instead of kmalloc() in the idmapper bjschuma
2012-08-10 10:10   ` William Dauchy
2012-08-10 16:16     ` Myklebust, Trond
2012-08-12 17:48       ` William Dauchy
2012-08-10 10:09 ` [PATCH 1/3] NFS: Clear key construction data if the idmap upcall fails William Dauchy
2012-08-16 13:45   ` William Dauchy
2012-08-16 15:07     ` William Dauchy
2012-08-16 15:21       ` Bryan Schumaker [this message]
2012-08-16 15:34         ` William Dauchy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502D0FF3.8010302@netapp.com \
    --to=bjschuma@netapp.com \
    --cc=Trond.Myklebust@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=wdauchy@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).