From: Bryan Schumaker <bjschuma@netapp.com>
To: bfields@fieldses.org
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 00/10] NFSD: Improve fault injection
Date: Wed, 03 Oct 2012 13:47:06 -0400 [thread overview]
Message-ID: <506C7A1A.5000001@netapp.com> (raw)
In-Reply-To: <1347912979-20603-1-git-send-email-bjschuma@netapp.com>
Bruce, have you had a chance to look at these yet? I don't see them in your git tree...
- Bryan
On 09/17/2012 04:16 PM, bjschuma@netapp.com wrote:
> From: Bryan Schumaker <bjschuma@netapp.com>
>
> While working on p2p-nfs, I discovered that I sometimes need to clear
> state for a specific client to test all possible error recovery conditions.
> The current fault injection code deletes state as it find it, so it can
> be difficult to guess which state will be forgotten. In addition, I
> currently print out the amount of state forgotten but I don't give details
> like "Forgot 3 locks from client w.x.y.z". These patches set out to
> improve that.
>
> The first 7 patches clean up the current code and prepare it for specific
> client state removal. Patch 8 adds prints information to the server's logs
> when a fault injection file is read (such as "Client w.x.y.z has 3 open
> files"). Patch 9 adds in a custom file operations structure so users can
> write strings to fault injection files in addition to u64s. Finally, patch
> 10 allows users to remove state by writing a client's IP address to one of
> the files.
>
> Questions, comments and suggestions are appreciated!
>
> - Bryan
>
> Bryan Schumaker (10):
> NFSD: Fold fault_inject.h into state.h
> NFSD: Lock state before calling fault injection function
> NFSD: Clean up forgetting clients
> NFSD: Clean up forgetting locks
> NFSD: Clean up forgetting openowners
> NFSD: Clean up forgetting and recalling delegations
> NFSD: Fault injection operations take a per-client forget function
> NFSD: Reading a fault injection file prints a state count
> NFSD: Add a custom file operations structure for fault injection
> NFSD: Forget state for a specific client
>
> fs/nfsd/fault_inject.c | 108 ++++++++++++++++++++++++-----
> fs/nfsd/fault_inject.h | 28 --------
> fs/nfsd/nfs4state.c | 182 +++++++++++++++++++++++++++++++------------------
> fs/nfsd/nfsctl.c | 2 +-
> fs/nfsd/state.h | 23 +++++++
> 5 files changed, 230 insertions(+), 113 deletions(-)
> delete mode 100644 fs/nfsd/fault_inject.h
>
next prev parent reply other threads:[~2012-10-03 17:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 20:16 [PATCH 00/10] NFSD: Improve fault injection bjschuma
2012-09-17 20:16 ` [PATCH 01/10] NFSD: Fold fault_inject.h into state.h bjschuma
2012-09-17 20:16 ` [PATCH 02/10] NFSD: Lock state before calling fault injection function bjschuma
2012-09-17 20:16 ` [PATCH 03/10] NFSD: Clean up forgetting clients bjschuma
2012-09-17 20:16 ` [PATCH 04/10] NFSD: Clean up forgetting locks bjschuma
2012-09-17 20:16 ` [PATCH 05/10] NFSD: Clean up forgetting openowners bjschuma
2012-09-17 20:16 ` [PATCH 06/10] NFSD: Clean up forgetting and recalling delegations bjschuma
2012-09-17 20:16 ` [PATCH 07/10] NFSD: Fault injection operations take a per-client forget function bjschuma
2012-09-17 20:16 ` [PATCH 08/10] NFSD: Reading a fault injection file prints a state count bjschuma
2012-09-17 20:16 ` [PATCH 09/10] NFSD: Add a custom file operations structure for fault injection bjschuma
2012-09-17 20:16 ` [PATCH 10/10] NFSD: Forget state for a specific client bjschuma
2012-10-03 17:47 ` Bryan Schumaker [this message]
2012-10-03 18:23 ` [PATCH 00/10] NFSD: Improve fault injection J. Bruce Fields
2012-10-03 18:24 ` Bryan Schumaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506C7A1A.5000001@netapp.com \
--to=bjschuma@netapp.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).