From: Steve Dickson <SteveD@redhat.com>
To: "Mantas Mikulėnas" <grawity@gmail.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] utils: Return status 0 on clean exits
Date: Mon, 15 Oct 2012 16:14:44 -0400 [thread overview]
Message-ID: <507C6EB4.60006@RedHat.com> (raw)
In-Reply-To: <1349478866-680992-1-git-send-email-grawity@gmail.com>
On 05/10/12 19:14, Mantas Mikulėnas wrote:
> Some init systems actually expect daemons to return 0 on success.
> ---
> utils/gssd/gssd.c | 2 +-
> utils/gssd/svcgssd.c | 2 +-
> utils/mountd/mountd.c | 3 ++-
> utils/statd/statd.c | 3 ++-
> 4 files changed, 6 insertions(+), 4 deletions(-)
Committed....
steved.
>
> diff --git a/utils/gssd/gssd.c b/utils/gssd/gssd.c
> index 7825255..a3292c9 100644
> --- a/utils/gssd/gssd.c
> +++ b/utils/gssd/gssd.c
> @@ -71,7 +71,7 @@ sig_die(int signal)
> if (root_uses_machine_creds)
> gssd_destroy_krb5_machine_creds();
> printerr(1, "exiting on signal %d\n", signal);
> - exit(1);
> + exit(0);
> }
>
> void
> diff --git a/utils/gssd/svcgssd.c b/utils/gssd/svcgssd.c
> index 1afff9e..8aee3b2 100644
> --- a/utils/gssd/svcgssd.c
> +++ b/utils/gssd/svcgssd.c
> @@ -153,7 +153,7 @@ sig_die(int signal)
> {
> /* destroy krb5 machine creds */
> printerr(1, "exiting on signal %d\n", signal);
> - exit(1);
> + exit(0);
> }
>
> void
> diff --git a/utils/mountd/mountd.c b/utils/mountd/mountd.c
> index bcf5080..993b6e6 100644
> --- a/utils/mountd/mountd.c
> +++ b/utils/mountd/mountd.c
> @@ -196,7 +196,8 @@ killer (int sig)
> wait_for_workers();
> }
> cleanup_lockfiles();
> - xlog (L_FATAL, "Caught signal %d, un-registering and exiting.", sig);
> + xlog (L_NOTICE, "Caught signal %d, un-registering and exiting.", sig);
> + exit(0);
> }
>
> static void
> diff --git a/utils/statd/statd.c b/utils/statd/statd.c
> index 01fdb41..652546c 100644
> --- a/utils/statd/statd.c
> +++ b/utils/statd/statd.c
> @@ -99,7 +99,8 @@ static void
> killer (int sig)
> {
> statd_unregister ();
> - xlog_err ("Caught signal %d, un-registering and exiting", sig);
> + xlog(D_GENERAL, "Caught signal %d, un-registering and exiting", sig);
> + exit(0);
> }
>
> static void
> -- 1.7.12.2 -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2012-10-15 20:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 23:14 [PATCH] utils: Return status 0 on clean exits Mantas Mikulėnas
2012-10-15 20:14 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507C6EB4.60006@RedHat.com \
--to=steved@redhat.com \
--cc=grawity@gmail.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).