public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: Christoph Hellwig <hch@lst.de>,
	Chuck Lever <chuck.lever@oracle.com>,
	 Trond Myklebust <trondmy@kernel.org>,
	Anna Schumaker <anna@kernel.org>
Cc: NeilBrown <neil@brown.name>,
	Olga Kornievskaia <okorniev@redhat.com>,
	 Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
	linux-nfs@vger.kernel.org
Subject: Re: [PATCH 3/3] sunrpc: unexport csum_partial_copy_to_xdr
Date: Tue, 13 May 2025 07:16:30 -0500	[thread overview]
Message-ID: <507c584df83c68411e7a3171303a658bb112525d.camel@kernel.org> (raw)
In-Reply-To: <20250513085739.894150-4-hch@lst.de>

On Tue, 2025-05-13 at 10:57 +0200, Christoph Hellwig wrote:
> csum_partial_copy_to_xdr is only used inside the sunrpc module, so
> remove the export.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  net/sunrpc/socklib.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/sunrpc/socklib.c b/net/sunrpc/socklib.c
> index 7196e7042e0f..68b16f2ba686 100644
> --- a/net/sunrpc/socklib.c
> +++ b/net/sunrpc/socklib.c
> @@ -158,7 +158,6 @@ int csum_partial_copy_to_xdr(struct xdr_buf *xdr, struct sk_buff *skb)
>  		return -1;
>  	return 0;
>  }
> -EXPORT_SYMBOL_GPL(csum_partial_copy_to_xdr);
>  
>  static inline int xprt_sendmsg(struct socket *sock, struct msghdr *msg,
>  			       size_t seek)

Reviewed-by: Jeff Layton <jlayton@kernel.org>

  reply	other threads:[~2025-05-13 12:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-13  8:57 small sunrpc cleanups Christoph Hellwig
2025-05-13  8:57 ` [PATCH 1/3] sunrpc: simplify xdr_init_encode_pages Christoph Hellwig
2025-05-13 12:15   ` Jeff Layton
2025-05-13  8:57 ` [PATCH 2/3] sunrpc: simplify xdr_partial_copy_from_skb Christoph Hellwig
2025-05-13 12:15   ` Jeff Layton
2025-05-14  5:05     ` Christoph Hellwig
2025-05-13  8:57 ` [PATCH 3/3] sunrpc: unexport csum_partial_copy_to_xdr Christoph Hellwig
2025-05-13 12:16   ` Jeff Layton [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-05-15 11:48 small sunrpc cleanups v2 Christoph Hellwig
2025-05-15 11:48 ` [PATCH 3/3] sunrpc: unexport csum_partial_copy_to_xdr Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=507c584df83c68411e7a3171303a658bb112525d.camel@kernel.org \
    --to=jlayton@kernel.org \
    --cc=Dai.Ngo@oracle.com \
    --cc=anna@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=hch@lst.de \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neil@brown.name \
    --cc=okorniev@redhat.com \
    --cc=tom@talpey.com \
    --cc=trondmy@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox