From: Steve Dickson <SteveD@redhat.com>
To: Steve Dickson <steved@redhat.com>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] svcgssd: Encryption types not being parsed correctly
Date: Mon, 19 Nov 2012 10:53:02 -0500 [thread overview]
Message-ID: <50AA55DE.50206@RedHat.com> (raw)
In-Reply-To: <1353160661-30105-1-git-send-email-steved@redhat.com>
On 17/11/12 08:57, Steve Dickson wrote:
> When svcgssd reads the supported encrytion types from the
> kernel, they are prefixed with a 'enctypes='. That prefix
> has to be ignored to correctly parse the rest of the types.
>
> Signed-off-by: Steve Dickson <steved@redhat.com>
Committed...
steved.
> ---
> utils/gssd/svcgssd_krb5.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/utils/gssd/svcgssd_krb5.c b/utils/gssd/svcgssd_krb5.c
> index 6c34faf..1d44d34 100644
> --- a/utils/gssd/svcgssd_krb5.c
> +++ b/utils/gssd/svcgssd_krb5.c
> @@ -38,6 +38,7 @@
>
> #include <stdio.h>
> #include <errno.h>
> +#include <ctype.h>
> #include <gssapi/gssapi.h>
> #include <krb5.h>
>
> @@ -98,6 +99,12 @@ parse_enctypes(char *enctypes)
> if (n == 0)
> return ENOENT;
>
> + /* Skip pass any non digits */
> + while (*enctypes && isdigit(*enctypes) == 0)
> + enctypes++;
> + if (*enctypes == '\0')
> + return EINVAL;
> +
> /* Allocate space for enctypes array */
> if ((parsed_enctypes = (int *) calloc(n, sizeof(int))) == NULL) {
> return ENOMEM;
>
prev parent reply other threads:[~2012-11-19 15:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-17 13:57 [PATCH] svcgssd: Encryption types not being parsed correctly Steve Dickson
2012-11-19 15:53 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AA55DE.50206@RedHat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).