From: Steve Dickson <SteveD@redhat.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [RFC PATCH V2] mount: Added the -o v4.1 mount option
Date: Mon, 19 Nov 2012 16:51:13 -0500 [thread overview]
Message-ID: <50AAA9D1.2010705@RedHat.com> (raw)
In-Reply-To: <30DFD4FD-3442-4F35-B576-EA597E21F4CE@oracle.com>
On 19/11/12 13:21, Chuck Lever wrote:
>
> As Trond points out, mount.nfs really should not use option "minorversion=" here, except on kernels that do not support "vers=4.x". That will add complexity, certainly.
I agree... The patch I put out today was just an RFC... I just wanted to get the conversation started...
>
> In addition, I think we can expect the need for support for "v4.2" and "v4.0" (perhaps) in the near future, and then subsequently "v4.3" and so on. Since that is close at hand, we should consider the need to add those as we design this.
Right, I thinking bring this type of negotiation back up to userland is the right thing to do...
>
> Perhaps instead of editing the mount option string directly in nfs_nfs_version(), you might add a "*minorversion" argument to nfs_nfs_version() function and let its callers finish the work, just as is done with "*version" today. That might also make it easier to add the logic that changes behavior based on kernel version.
Let me digest this... I've noticed that in recent kernels that minorversion always seems to be set...
steved.
prev parent reply other threads:[~2012-11-19 21:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 15:43 [RFC PATCH V2] mount: Added the -o v4.1 mount option Steve Dickson
2012-11-19 15:54 ` Myklebust, Trond
2012-11-19 15:58 ` Steve Dickson
2012-11-19 16:02 ` Myklebust, Trond
2012-11-19 16:14 ` Steve Dickson
2012-11-19 16:24 ` Myklebust, Trond
2012-11-19 18:11 ` Chuck Lever
2012-11-19 18:29 ` Myklebust, Trond
2012-11-19 18:39 ` Chuck Lever
2012-11-19 19:04 ` Myklebust, Trond
2012-11-19 21:15 ` J. Bruce Fields
2012-11-19 21:40 ` Steve Dickson
2012-11-19 18:21 ` Chuck Lever
2012-11-19 21:51 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AAA9D1.2010705@RedHat.com \
--to=steved@redhat.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).