linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stanislav Kinsbursky <skinsbursky@parallels.com>
To: Eric Paris <eparis@parisplace.org>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>,
	Bruce Fields <bfields@fieldses.org>,
	Linux-NFS <linux-nfs@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	<devel@openvz.org>
Subject: Re: [PATCH] SUNRPC: connect to UNIX sockets synchronously
Date: Wed, 5 Dec 2012 11:48:34 +0400	[thread overview]
Message-ID: <50BEFC52.8030902@parallels.com> (raw)
In-Reply-To: <CACLa4psccEppztVNBAvXBFwvMBaOfsJWbrw7u39x1iT0D6o8sA@mail.gmail.com>

04.12.2012 18:20, Eric Paris пишет:
> On Tue, Dec 4, 2012 at 6:10 AM, Stanislav Kinsbursky
> <skinsbursky@parallels.com> wrote:
>
>> But there should be noted, that such implementation introduces limitation
>> (Trond's quote):
>> "That approach can fall afoul of the selinux restrictions on the process
>> context. Processes that are allowed to write data, may not be allowed to
>> create sockets or call connect(). That is the main reason for doing it
>> in the rpciod context, which is a clean kernel process context."
>
> So you tested this and Trond was wrong?  This work just fine even on
> an SELinux box?  Or it does break tons and tons of people's computers?
>
> -Eric
>

You can read discussion here:
https://patchwork.kernel.org/patch/1565111/

We use AF_LOCAL transports only for portmapper calls.
So, we decided (or at least I understood that so) to make such connections
from process context - i.e. synchronously.

-- 
Best regards,
Stanislav Kinsbursky

      reply	other threads:[~2012-12-05  7:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-04 11:10 [PATCH] SUNRPC: connect to UNIX sockets synchronously Stanislav Kinsbursky
2012-12-04 14:20 ` Eric Paris
2012-12-05  7:48   ` Stanislav Kinsbursky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50BEFC52.8030902@parallels.com \
    --to=skinsbursky@parallels.com \
    --cc=Trond.Myklebust@netapp.com \
    --cc=bfields@fieldses.org \
    --cc=devel@openvz.org \
    --cc=eparis@parisplace.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).