From: Benny Halevy <bhalevy@tonian.com>
To: Marc Eshel <eshel@us.ibm.com>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>,
"J. Bruce Fields" <bfields@redhat.com>,
linux-nfs-owner@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: notify_deviceid_type4
Date: Sun, 09 Dec 2012 11:42:47 +0200 [thread overview]
Message-ID: <50C45D17.5090000@tonian.com> (raw)
In-Reply-To: <OFF752FE87.86716271-ON88257AC7.002025E3-88257AC7.00206C04@us.ibm.com>
On 2012-12-01 07:54, Marc Eshel wrote:
> The spec defines notify_deviceid_type4 as:
>
> 20.12.1. ARGUMENT
> /*
> * Device notification types.
> */
> enum notify_deviceid_type4 {
> NOTIFY_DEVICEID4_CHANGE = 1,
> NOTIFY_DEVICEID4_DELETE = 2
> };
>
>
> but the Linux code in nfs4.h has, is that going to be fixed?
>
> enum pnfs_notify_deviceid_type4 {
> NOTIFY_DEVICEID4_CHANGE = 1 << 1,
> NOTIFY_DEVICEID4_DELETE = 1 << 2,
> };
notify_deviceid_type4 specifies bit numbers same as notify_type4
It seems to me like the definition in nfs4.h is correct.
Benny
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-12-09 9:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-01 5:54 notify_deviceid_type4 Marc Eshel
2012-12-09 9:42 ` Benny Halevy [this message]
2012-12-09 16:43 ` notify_deviceid_type4 Marc Eshel
[not found] ` <CAEMWVhsh0SvLX8MY8cghOmbYExpqFLYgUFVuai_RyaYu3EErvw@mail.gmail.com>
2012-12-09 18:05 ` notify_deviceid_type4 Marc Eshel
[not found] ` <CAEMWVhv3GwJh1nTNYeCm4AnrDVdZbrJLS4DeKn4C6iHkJ5-jbA@mail.gmail.com>
2012-12-09 21:46 ` notify_deviceid_type4 Marc Eshel
2012-12-10 2:51 ` notify_deviceid_type4 Marc Eshel
2012-12-11 11:20 ` notify_deviceid_type4 Benny Halevy
2012-12-11 19:01 ` notify_deviceid_type4 Marc Eshel
[not found] <OFF752FE87.86716271-ON88257AC7.002025E3-88257AC7.00206C04@LocalDomain>
[not found] ` <OF13B342CA.3B3F39AC-ON88257ACD.0080BC4F-88257ACD.00815AED@LocalDomain>
2012-12-07 23:46 ` notify_deviceid_type4 Marc Eshel
[not found] ` <OF13B342CA.3B3F39AC-ON88257ACD.0080BC4F-88257ACD.00815B0B@us.ibm.com>
[not found] ` <4FA345DA4F4AE44899BD2B03EEEC2FA90B33D909@SACEXCMBX04-PRD.hq.netapp.com>
2012-12-08 0:10 ` notify_deviceid_type4 Marc Eshel
2012-12-08 1:24 ` notify_deviceid_type4 Jim Rees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C45D17.5090000@tonian.com \
--to=bhalevy@tonian.com \
--cc=Trond.Myklebust@netapp.com \
--cc=bfields@redhat.com \
--cc=eshel@us.ibm.com \
--cc=linux-nfs-owner@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).