[PATCH] rpc.idmapd: Ignore open failures in dirscancb()

[PATCH] rpc.idmapd: Ignore open failures in dirscancb()

[Steve Dickson]

From: David Jeffery <djeffery@redhat.com>

The daemon "rpc.idmapd" scans the /var/lib/nfs/rpc_pipefs/nfs/ directory
periodically looking for NFS client mounts to communicate to. The daemon
tried to open communication with a client mount but it disappeared in
between looking for directory entries and opening them. NFS mount was
umounted just before rpc.idmapd tried to communicate with it. This
behavior is usually seen when autofs is configured on the system.

Signed-off-by: Steve Dickson <steved@redhat.com>
---
 utils/idmapd/idmapd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/utils/idmapd/idmapd.c b/utils/idmapd/idmapd.c
index 9d66225..beba9c4 100644
--- a/utils/idmapd/idmapd.c
+++ b/utils/idmapd/idmapd.c
@@ -424,7 +424,8 @@ dirscancb(int UNUSED(fd), short UNUSED(which), void *data)
 			    pipefsdir, ents[i]->d_name);
 
 			if ((ic->ic_dirfd = open(path, O_RDONLY, 0)) == -1) {
-				xlog_warn("dirscancb: open(%s): %s", path, strerror(errno));
+				if (verbose > 0)
+					xlog_warn("dirscancb: open(%s): %s", path, strerror(errno));
 				free(ic);
 				goto out;
 			}
-- 
1.7.11.7

Re: [PATCH] rpc.idmapd: Ignore open failures in dirscancb()

[Steve Dickson]

On 02/01/13 13:47, Steve Dickson wrote:
> From: David Jeffery <djeffery@redhat.com>
> 
> The daemon "rpc.idmapd" scans the /var/lib/nfs/rpc_pipefs/nfs/ directory
> periodically looking for NFS client mounts to communicate to. The daemon
> tried to open communication with a client mount but it disappeared in
> between looking for directory entries and opening them. NFS mount was
> umounted just before rpc.idmapd tried to communicate with it. This
> behavior is usually seen when autofs is configured on the system.
> 
> Signed-off-by: Steve Dickson <steved@redhat.com>
Committed... 

steved.

> ---
>  utils/idmapd/idmapd.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/utils/idmapd/idmapd.c b/utils/idmapd/idmapd.c
> index 9d66225..beba9c4 100644
> --- a/utils/idmapd/idmapd.c
> +++ b/utils/idmapd/idmapd.c
> @@ -424,7 +424,8 @@ dirscancb(int UNUSED(fd), short UNUSED(which), void *data)
>  			    pipefsdir, ents[i]->d_name);
>  
>  			if ((ic->ic_dirfd = open(path, O_RDONLY, 0)) == -1) {
> -				xlog_warn("dirscancb: open(%s): %s", path, strerror(errno));
> +				if (verbose > 0)
> +					xlog_warn("dirscancb: open(%s): %s", path, strerror(errno));
>  				free(ic);
>  				goto out;
>  			}
>