linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Possible 'prev' leakage in nfs41_walk_client_list
Date: Fri, 18 Jan 2013 15:39:51 -0800	[thread overview]
Message-ID: <50F9DD47.707@candelatech.com> (raw)

[ A private conversation resulted in a 'if you can't show the problem in a real test case,
then we don't need a patch' response, so I'm posting publicly in case someone
else wants to cook up a patch. ]


While looking at the code, I noticed that the nfs40 version has some code to
release 'prev' in the failure case, but nfs41 version does not.

The code is complicated, but I believe prev can indeed leak in
this method, if the failure case code path is taken.  I have no proof
that the failure case is ever taken, but the 'nfs40' version
failure case can...

Perhaps someone more familiar with this code can cook up
a fix.

I'm not using this code in my test right now, so I have
no good way to test a patch at this point.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


                 reply	other threads:[~2013-01-18 23:39 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50F9DD47.707@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).