linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Possible 'prev' leakage in nfs41_walk_client_list
@ 2013-01-18 23:39 Ben Greear
  0 siblings, 0 replies; only message in thread
From: Ben Greear @ 2013-01-18 23:39 UTC (permalink / raw)
  To: linux-nfs@vger.kernel.org

[ A private conversation resulted in a 'if you can't show the problem in a real test case,
then we don't need a patch' response, so I'm posting publicly in case someone
else wants to cook up a patch. ]


While looking at the code, I noticed that the nfs40 version has some code to
release 'prev' in the failure case, but nfs41 version does not.

The code is complicated, but I believe prev can indeed leak in
this method, if the failure case code path is taken.  I have no proof
that the failure case is ever taken, but the 'nfs40' version
failure case can...

Perhaps someone more familiar with this code can cook up
a fix.

I'm not using this code in my test right now, so I have
no good way to test a patch at this point.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2013-01-18 23:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-18 23:39 Possible 'prev' leakage in nfs41_walk_client_list Ben Greear

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).