From: Benny Halevy <bhalevy@tonian.com>
To: Fred Isaman <faisaman4@gmail.com>
Cc: "Myklebust, Trond" <Trond.Myklebust@netapp.com>,
"Isaman, Fred" <Fred.Isaman@netapp.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"stable@kernel.org" <stable@kernel.org>
Subject: Re: [PATCH] pnfs: do not reset to mds if wb_offset != wb_pgbase
Date: Tue, 19 Mar 2013 21:35:39 +0200 [thread overview]
Message-ID: <5148BE0B.9080802@tonian.com> (raw)
In-Reply-To: <CADnza476e0FpXJJfE8OmXLRQUR3Zm_aZkX7JZRB=vGyZ-U2yDg@mail.gmail.com>
On 2013-03-18 19:04, Fred Isaman wrote:
> On Mon, Mar 18, 2013 at 12:22 PM, Benny Halevy <bhalevy@tonian.com> wrote:
>
>>> NACK. I see no evidence that we've addressed the issues that were raised
>>> by Fred in commit 1825a0d08f22463e5a8f4b1636473efd057a3479 (NFS: prepare
>>> coalesce testing for directio).
>>> If you think that his concerns about the coalescing assumptions are no
>>> longer true, then please point to why this is the case. AFAICR that
>>> patch was added to fix corruption issues.
>>>
>>
>> We see no problems with this patch with the workloads we're testing.
>> Do you have a test that reproduces the original problem that we can try running?
>>
>> Benny
>
> A problem case is if the layout ends within the page request, which
> can happen due to the misalignment.
First, the file layout currently supports only whole file layouts so I don't see
how that's a problem.
Regardless, I'd rather trim the layout segment to PAGE_SIZE boundaries
and get a new layout from the page aligned offset and on with minlength = PAGE_SIZE
(as we do today).
Benny
>
> Fred
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-03-19 19:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1363617532-24172-1-git-send-email-bhalevy@tonian.com>
2013-03-18 15:55 ` [PATCH] pnfs: do not reset to mds if wb_offset != wb_pgbase Myklebust, Trond
2013-03-18 16:22 ` Benny Halevy
2013-03-18 16:39 ` Myklebust, Trond
2013-03-18 16:45 ` Benny Halevy
2013-03-18 17:09 ` Myklebust, Trond
2013-03-18 17:04 ` Fred Isaman
2013-03-19 19:35 ` Benny Halevy [this message]
2013-03-19 20:28 ` Fred Isaman
2013-03-19 20:38 ` Benny Halevy
2013-03-27 12:19 ` Benny Halevy
2013-04-28 15:20 ` Benny Halevy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5148BE0B.9080802@tonian.com \
--to=bhalevy@tonian.com \
--cc=Fred.Isaman@netapp.com \
--cc=Trond.Myklebust@netapp.com \
--cc=faisaman4@gmail.com \
--cc=linux-nfs@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).