* [PATCH - nfs-utils] gssd: use correct test for success of getrlimit()
@ 2013-02-19 0:31 NeilBrown
2013-03-25 14:15 ` Steve Dickson
0 siblings, 1 reply; 2+ messages in thread
From: NeilBrown @ 2013-02-19 0:31 UTC (permalink / raw)
To: Steve Dickson; +Cc: NFS, Leonardo Chiquitto
[-- Attachment #1: Type: text/plain, Size: 975 bytes --]
commit 7c5cb5e732a4b8704f8c79ec819c5d271e040339
gssd: base the size of the fd array on the RLIMIT_NOFILE limit.
didn't actually work as claimed. It only uses the returned value
if getrlimit() returns -1 -- which of course it only does when
there was an error.
So change the test to "== 0".
Reported-by: Leonardo Chiquitto< lchiquitto@suse.com>
Signed-off-by: NeilBrown <neilb@suse.de>
--
hangs head in shame .... NeilBrown
diff --git a/utils/gssd/gssd_proc.c b/utils/gssd/gssd_proc.c
index c17ab3b..e10bda6 100644
--- a/utils/gssd/gssd_proc.c
+++ b/utils/gssd/gssd_proc.c
@@ -477,7 +477,7 @@ init_client_list(void)
TAILQ_INIT(&clnt_list);
/* Eventually plan to grow/shrink poll array: */
pollsize = FD_ALLOC_BLOCK;
- if (getrlimit(RLIMIT_NOFILE, &rlim) < 0 &&
+ if (getrlimit(RLIMIT_NOFILE, &rlim) == 0 &&
rlim.rlim_cur != RLIM_INFINITY)
pollsize = rlim.rlim_cur;
pollarray = calloc(pollsize, sizeof(struct pollfd));
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH - nfs-utils] gssd: use correct test for success of getrlimit()
2013-02-19 0:31 [PATCH - nfs-utils] gssd: use correct test for success of getrlimit() NeilBrown
@ 2013-03-25 14:15 ` Steve Dickson
0 siblings, 0 replies; 2+ messages in thread
From: Steve Dickson @ 2013-03-25 14:15 UTC (permalink / raw)
To: NeilBrown; +Cc: NFS, Leonardo Chiquitto
On 18/02/13 19:31, NeilBrown wrote:
>
> commit 7c5cb5e732a4b8704f8c79ec819c5d271e040339
> gssd: base the size of the fd array on the RLIMIT_NOFILE limit.
>
> didn't actually work as claimed. It only uses the returned value
> if getrlimit() returns -1 -- which of course it only does when
> there was an error.
>
> So change the test to "== 0".
>
> Reported-by: Leonardo Chiquitto< lchiquitto@suse.com>
> Signed-off-by: NeilBrown <neilb@suse.de>
>
> --
> hangs head in shame .... NeilBrown
Committed...
steved.
>
> diff --git a/utils/gssd/gssd_proc.c b/utils/gssd/gssd_proc.c
> index c17ab3b..e10bda6 100644
> --- a/utils/gssd/gssd_proc.c
> +++ b/utils/gssd/gssd_proc.c
> @@ -477,7 +477,7 @@ init_client_list(void)
> TAILQ_INIT(&clnt_list);
> /* Eventually plan to grow/shrink poll array: */
> pollsize = FD_ALLOC_BLOCK;
> - if (getrlimit(RLIMIT_NOFILE, &rlim) < 0 &&
> + if (getrlimit(RLIMIT_NOFILE, &rlim) == 0 &&
> rlim.rlim_cur != RLIM_INFINITY)
> pollsize = rlim.rlim_cur;
> pollarray = calloc(pollsize, sizeof(struct pollfd));
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-25 14:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-19 0:31 [PATCH - nfs-utils] gssd: use correct test for success of getrlimit() NeilBrown
2013-03-25 14:15 ` Steve Dickson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).