From: Steve Dickson <SteveD@redhat.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH [nfs-utils]] do not fail sqlite check when cross-compiling
Date: Mon, 22 Apr 2013 13:19:24 -0400 [thread overview]
Message-ID: <5175711C.2090504@RedHat.com> (raw)
In-Reply-To: <1365883476-5288-1-git-send-email-vapier@gentoo.org>
On 13/04/13 16:04, Mike Frysinger wrote:
> If we're cross-compiling, we can't do a runtime test of sqlite,
> so just assume that the user has a good enough version rather
> than falling over.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Committed...
steved.
> ---
> configure.ac | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 3d7ab0a..a594a7b 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -274,9 +274,14 @@ if test "$enable_nfsv4" = yes; then
> AC_CHECK_HEADERS([libgen.h sys/inotify.h], ,
> AC_MSG_ERROR([Cannot find header needed for nfsdcltrack]))
>
> - if test "$libsqlite3_cv_is_recent" != "yes" ; then
> - AC_MSG_ERROR([nfsdcltrack requires sqlite-devel])
> - fi
> + case $libsqlite3_cv_is_recent in
> + yes) ;;
> + unknown)
> + dnl do not fail when cross-compiling
> + AC_MSG_WARN([assuming sqlite is at least v3.3]) ;;
> + *)
> + AC_MSG_ERROR([nfsdcltrack requires sqlite-devel]) ;;
> + esac
> fi
>
> else
>
prev parent reply other threads:[~2013-04-22 17:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-13 20:04 [PATCH [nfs-utils]] do not fail sqlite check when cross-compiling Mike Frysinger
2013-04-13 20:04 ` [PATCH [nfs-utils]] ignore more generated files Mike Frysinger
2013-04-22 17:19 ` Steve Dickson
2013-04-22 17:19 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5175711C.2090504@RedHat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).