From: Tom Talpey <tom@talpey.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Sandeep Joshi <sanjos100@gmail.com>, linux-nfs@vger.kernel.org
Subject: Re: why does nfsd write not use splice
Date: Tue, 11 Jun 2013 22:36:12 -0400 [thread overview]
Message-ID: <51B7DE9C.6080703@talpey.com> (raw)
In-Reply-To: <20130611195140.GA29634@fieldses.org>
On 6/11/2013 3:51 PM, J. Bruce Fields wrote:
> On Sun, Jun 09, 2013 at 01:05:16PM +0530, Sandeep Joshi wrote:
>> Is there a reason as to why the nfsd server does not use splice in the
>> write calls - nfsd_vfs_write() ? Is there some structural limitation
>> or is it just something nobody got around to implementing ?
>>
>> I have looked at the source back to the 2.6.x kernels and it seems
>> only nfsd_vfs_read() has ever used splice/sendfile.
>> http://lxr.linux.no/linux+v3.9.5/fs/nfsd/vfs.c
>
> I don't actually know how splice_write works.... I assume to avoid a
> copy we'd have to place the incoming write data into pages already
> correctly aligned. That would be an interesting trick.
NFS-RDMA does that, by design. ;-)
next prev parent reply other threads:[~2013-06-12 2:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-09 7:35 why does nfsd write not use splice Sandeep Joshi
2013-06-11 19:51 ` J. Bruce Fields
2013-06-12 2:36 ` Tom Talpey [this message]
2013-06-12 15:39 ` J. Bruce Fields
2013-06-12 16:22 ` Sandeep Joshi
[not found] ` <CAEfL3KkdjB7bzvnfiDh024kHjCH0e64iH6GK6y+A+bpH3kUgJg@mail.gmail.com>
2013-06-12 16:46 ` J. Bruce Fields
2013-06-14 12:09 ` Sandeep Joshi
2013-06-14 19:22 ` Jeff Layton
2013-06-15 5:09 ` Myklebust, Trond
2013-06-17 11:01 ` Jeff Layton
2013-06-17 11:48 ` Myklebust, Trond
2013-06-17 14:34 ` J. Bruce Fields
2013-06-17 14:36 ` Myklebust, Trond
2013-06-17 14:48 ` J. Bruce Fields
2013-06-18 12:17 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B7DE9C.6080703@talpey.com \
--to=tom@talpey.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=sanjos100@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox