linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stanislav Kinsbursky <skinsbursky@parallels.com>
To: Jeff Layton <jlayton@redhat.com>
Cc: "bfields@fieldses.org" <bfields@fieldses.org>, linux-nfs@vger.kernel.org
Subject: Re: NFS inode cache zap on lock - please advice
Date: Fri, 19 Jul 2013 11:08:15 +0400	[thread overview]
Message-ID: <51E8E5DF.7010405@parallels.com> (raw)
In-Reply-To: <20130715071119.7997d9ce@corrin.poochiereds.net>

15.07.2013 15:11, Jeff Layton пишет:
> On Mon, 15 Jul 2013 11:16:39 +0400
> Stanislav Kinsbursky <skinsbursky@parallels.com> wrote:
>
>> 13.07.2013 00:52, bfields@fieldses.org пишет:
>>> On Thu, May 30, 2013 at 04:01:42PM +0400, Stanislav Kinsbursky wrote:
>>>> Thanks, Bruce!
>>>> I'll have at
>>>>
>>>> BTW, do you have any decisions what we will do with UMH tracker?
>>> Crap, apologies, I completely dropped this.  Have you looked at it
>>> again lately?
>> Don't worry, it's all right. And I added Jeff and mailing list to
>> recipients.
>>
>> I was thinking about using kernel_thread() instead of kthread_create().
>> This might work, because will give us kthread with same root and same
>> capabilities as mount caller had.
>>
>> What you, guys, think about it?
> Well, it's not the caller of mount that we're concerned with here. It's
> the caller of rpc.nfsd. That program is going to make the kernel spawn
> a bunch of nfsd kthreads and then exit. So I guess the basic idea here
> is to preserve the namespace info, root and creds from that process
> before it exits. Spawning a kthread would work for that, and might be
> simplest, but we should weigh this idea carefully before we settle on
> it.
>
> Let's assume for a moment that we want to do all of this in userspace
> instead (Eric B.'s first suggestion). I assume the kernel would need to
> pass a fd to the program so it can call setns() with it. Where would it
> get this fd, considering that we're calling this from a nfsd kthread?
>
> What else would it need? Would it need a path to chroot() to? Credential
> info so it can call setuid/setgid?
>
> Other caveats might be that the binary needn't exist in the container
> to which you're chrooting. That's not really a problem as long as all
> the libs get linked in before the program does the switcharoo, but it
> might make troubleshooting problems in this code difficult from a
> user sitting in that container.
>

As far as I understand the user namespaces idea, the all it covers are 
process credentials.
And for running the binary we need only mount and path.
My first approach was to swap root in UMH init callback. This works. But 
doesn't take user namespaces into account at all.
If we assume, that a user, which is capable to run rpc.nfsd is also must 
be capable to run the UMH binary, then we can just forget about a 
user-namespace isolation and use this UMH init callback. It's cheap to 
implement. But it's not flawless, because looks like a dirty hack (which 
it is, actually).
Another way (with taking of user namespaces into account) is a kernel 
thread, forked in process context (i.e. kernel_thread() call). This will 
give us all the same credentials, root and namespaces, as rpc.nfsd 
caller has, for the UMH binary caller.
But this solution requires of local implementation of a 
____call_usermodehelper() function content. And a bunch of it's calls 
are not exported to modules. So it's a hack again, which looks even 
worse to me.
IOW, I don't see any comfortable existent solution for this task. But 
the first one is just simpler.
And this is all because kernel thread are working in initial namespaces 
including file system root.


  reply	other threads:[~2013-07-19  7:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <51A6EC86.9010201@parallels.com>
     [not found] ` <20130530114216.GA11854@fieldses.org>
     [not found]   ` <51A73FA6.30503@parallels.com>
     [not found]     ` <20130712205242.GB10562@fieldses.org>
2013-07-15  7:16       ` NFS inode cache zap on lock - please advice Stanislav Kinsbursky
2013-07-15 11:11         ` Jeff Layton
2013-07-19  7:08           ` Stanislav Kinsbursky [this message]
2013-07-24 20:02             ` bfields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E8E5DF.7010405@parallels.com \
    --to=skinsbursky@parallels.com \
    --cc=bfields@fieldses.org \
    --cc=jlayton@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).