From: ben <ben@appliedplastic.com>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: Karl Schmidt <karl@xtronics.com>,
Jonathan McDowell <noodles@earth.li>,
Dave Kleikamp <dave.kleikamp@oracle.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
jfs-discussion@lists.sourceforge.net, 714974@bugs.debian.org,
linux-nfs@vger.kernel.org,
Christian Kujau <lists@nerdbynature.de>
Subject: Re: [JunkMail] Re: [PATCH] jfs: fix readdir cookie incompatibility with NFSv4
Date: Mon, 19 Aug 2013 13:11:14 -0600 [thread overview]
Message-ID: <52126DD2.6090006@appliedplastic.com> (raw)
In-Reply-To: <1376769691.2544.4.camel@deadeye.wl.decadent.org.uk>
On 8/17/2013 2:01 PM, Ben Hutchings wrote:
> On Thu, 2013-08-15 at 14:26 -0700, Christian Kujau wrote:
>> On Thu, 15 Aug 2013 at 15:48, Dave Kleikamp wrote:
>>> This patch replaces the one I posted yesterday. I like this better since
>>> it doesn't require fixing existing on-disk cookies or skipping a
>>> position in the in-inode index table.
>>
>> Thanks. Applied to 3.11-rc5 and tested, no more "readdir loop" messages
>> and with unique inode numbers, great!
>>
>> Tested-by: Christian Kujau <lists@nerdbynature.de>
>
> Karl and Jonathan, could you test the attached backport to 3.2?
>
> (Instructions for rebuilding the Debian kernel package are at:
> <http://kernel-handbook.alioth.debian.org/ch-common-tasks.html#s-common-official>)
>
> Ben.
>
When I read this the other day I thought It was a great idea, but when
sleeping on it I have this gut feeling that somewhere there is a
jfs_dirent->position--; missing but I don't have enough familiarity with
the code to begin to guess where. Hopefully I am wrong.
ben
--
Ben Hildred
Support Services
Applied Plastic Coatings, Inc.
5000 Tabor St.
Wheat Ridge, CO 80033
303 424 9200
F: 303 424 8800
ben@appliedplastic.com
http://appliedplastic.com
next prev parent reply other threads:[~2013-08-19 19:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 1:13 NFS 'readdir loop' error on JFS Ben Hutchings
2013-07-08 14:02 ` bjschuma
2013-07-08 15:43 ` Karl Schmidt
2013-08-09 20:44 ` Karl Schmidt
2013-08-10 7:28 ` [Jfs-discussion] " Christian Kujau
2013-08-10 19:43 ` Karl Schmidt
2013-08-12 8:18 ` Christian Kujau
2013-08-12 8:29 ` Christian Kujau
2013-08-12 16:29 ` J. Bruce Fields
2013-08-12 20:04 ` Christian Kujau
2013-08-15 3:54 ` [PATCH] jfs: avoid misuse of cookie value of 2 Dave Kleikamp
2013-08-15 4:29 ` Christian Kujau
2013-08-15 7:09 ` Christian Kujau
2013-08-15 13:38 ` Dave Kleikamp
2013-08-15 20:48 ` [PATCH] jfs: fix readdir cookie incompatibility with NFSv4 Dave Kleikamp
2013-08-15 21:26 ` Christian Kujau
2013-08-15 22:09 ` Dave Kleikamp
2013-08-17 20:01 ` Ben Hutchings
2013-08-19 19:11 ` ben [this message]
2013-08-29 22:48 ` Jonathan McDowell
2013-09-05 3:40 ` Bug#714974: " Jonathan McDowell
2013-08-24 22:21 ` [Jfs-discussion] " Christian Kujau
2013-08-26 22:27 ` Dave Kleikamp
2013-08-15 13:38 ` [PATCH] jfs: avoid misuse of cookie value of 2 J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52126DD2.6090006@appliedplastic.com \
--to=ben@appliedplastic.com \
--cc=714974@bugs.debian.org \
--cc=ben@decadent.org.uk \
--cc=bfields@fieldses.org \
--cc=dave.kleikamp@oracle.com \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=karl@xtronics.com \
--cc=linux-nfs@vger.kernel.org \
--cc=lists@nerdbynature.de \
--cc=noodles@earth.li \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).