From: Bryan Schumaker <bjschuma@netapp.com>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: <linux-nfs@vger.kernel.org>, Bryan Schumaker <bjschuma@netapp.com>
Subject: Re: [PATCH 4/6] NFSv4: Deal with a sparse warning in nfs_idmap_get_key()
Date: Thu, 22 Aug 2013 08:55:08 -0400 [thread overview]
Message-ID: <52160A2C.7000804@netapp.com> (raw)
In-Reply-To: <1377131186-40249-4-git-send-email-Trond.Myklebust@netapp.com>
On 08/21/2013 08:26 PM, Trond Myklebust wrote:
> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
> Cc: Bryan Schumaker <bjschuma@netapp.com>
> ---
> fs/nfs/idmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfs/idmap.c b/fs/nfs/idmap.c
> index c2c4163..65c7d91 100644
> --- a/fs/nfs/idmap.c
> +++ b/fs/nfs/idmap.c
> @@ -310,7 +310,7 @@ static ssize_t nfs_idmap_get_key(const char *name, size_t namelen,
> if (ret < 0)
> goto out_up;
>
> - payload = rcu_dereference(rkey->payload.data);
> + payload = rcu_dereference(rkey->payload.rcudata);
Loks good to me!
Acked-by: Bryan Schumaker <bjschuma@netapp.com>
> if (IS_ERR_OR_NULL(payload)) {
> ret = PTR_ERR(payload);
> goto out_up;
>
next prev parent reply other threads:[~2013-08-22 12:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 0:26 [PATCH 1/6] NFSv3: Deal with a sparse warning in nfs3_proc_create Trond Myklebust
2013-08-22 0:26 ` [PATCH 2/6] NFSv4: Deal with a sparse warning in nfs4_opendata_alloc Trond Myklebust
2013-08-22 0:26 ` [PATCH 3/6] NFSv4: Deal with some more sparse warnings Trond Myklebust
2013-08-22 0:26 ` [PATCH 4/6] NFSv4: Deal with a sparse warning in nfs_idmap_get_key() Trond Myklebust
2013-08-22 0:26 ` [PATCH 5/6] NFSv4: Fix an incorrect pointer declaration in decode_first_pnfs_layout_type Trond Myklebust
2013-08-22 0:26 ` [PATCH 6/6] NFS: Clean up nfs_sillyrename() Trond Myklebust
2013-08-22 12:55 ` Bryan Schumaker [this message]
2013-08-22 12:49 ` [PATCH 3/6] NFSv4: Deal with some more sparse warnings Chuck Lever
2013-08-22 14:12 ` [PATCH 1/6] NFSv3: Deal with a sparse warning in nfs3_proc_create Peter Staubach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52160A2C.7000804@netapp.com \
--to=bjschuma@netapp.com \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).