* [PATCH - nfs-utils] gssd: suppress error message if rpc_pipefs dir disappears.
@ 2013-09-02 4:57 NeilBrown
2013-09-05 16:02 ` Steve Dickson
0 siblings, 1 reply; 2+ messages in thread
From: NeilBrown @ 2013-09-02 4:57 UTC (permalink / raw)
To: Steve Dickson; +Cc: linux-nfs
[-- Attachment #1: Type: text/plain, Size: 1098 bytes --]
It is possible for a race to cause a name to appear when an rpc_pipefs
dir is scanned but to no longer be present when we try to open it.
So if the error is ENOENT, don't complain.
This is similar to
commit 5ac9bcfd820f09af4d3f87f1f7346d896f70bc9a
Author: David Jeffery <djeffery@redhat.com>
Date: Wed Jan 16 15:21:55 2013 -0500
rpc.idmapd: Ignore open failures in dirscancb()
which addressed a similar issue in idmapd.
Signed-off-by: NeilBrown <neilb@suse.de>
diff --git a/utils/gssd/gssd_proc.c b/utils/gssd/gssd_proc.c
index b7e2bbb..2d3dbec 100644
--- a/utils/gssd/gssd_proc.c
+++ b/utils/gssd/gssd_proc.c
@@ -467,8 +467,9 @@ process_clnt_dir(char *dir, char *pdir)
}
sprintf(clp->dirname, "%s/%s", pdir, dir);
if ((clp->dir_fd = open(clp->dirname, O_RDONLY)) == -1) {
- printerr(0, "ERROR: can't open %s: %s\n",
- clp->dirname, strerror(errno));
+ if (errno != ENOENT)
+ printerr(0, "ERROR: can't open %s: %s\n",
+ clp->dirname, strerror(errno));
goto fail_destroy_client;
}
fcntl(clp->dir_fd, F_SETSIG, DNOTIFY_SIGNAL);
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH - nfs-utils] gssd: suppress error message if rpc_pipefs dir disappears.
2013-09-02 4:57 [PATCH - nfs-utils] gssd: suppress error message if rpc_pipefs dir disappears NeilBrown
@ 2013-09-05 16:02 ` Steve Dickson
0 siblings, 0 replies; 2+ messages in thread
From: Steve Dickson @ 2013-09-05 16:02 UTC (permalink / raw)
To: NeilBrown; +Cc: linux-nfs
On 02/09/13 00:57, NeilBrown wrote:
> It is possible for a race to cause a name to appear when an rpc_pipefs
> dir is scanned but to no longer be present when we try to open it.
>
> So if the error is ENOENT, don't complain.
>
> This is similar to
>
> commit 5ac9bcfd820f09af4d3f87f1f7346d896f70bc9a
> Author: David Jeffery <djeffery@redhat.com>
> Date: Wed Jan 16 15:21:55 2013 -0500
>
> rpc.idmapd: Ignore open failures in dirscancb()
>
> which addressed a similar issue in idmapd.
>
> Signed-off-by: NeilBrown <neilb@suse.de>
Committed!
steved.
>
> diff --git a/utils/gssd/gssd_proc.c b/utils/gssd/gssd_proc.c
> index b7e2bbb..2d3dbec 100644
> --- a/utils/gssd/gssd_proc.c
> +++ b/utils/gssd/gssd_proc.c
> @@ -467,8 +467,9 @@ process_clnt_dir(char *dir, char *pdir)
> }
> sprintf(clp->dirname, "%s/%s", pdir, dir);
> if ((clp->dir_fd = open(clp->dirname, O_RDONLY)) == -1) {
> - printerr(0, "ERROR: can't open %s: %s\n",
> - clp->dirname, strerror(errno));
> + if (errno != ENOENT)
> + printerr(0, "ERROR: can't open %s: %s\n",
> + clp->dirname, strerror(errno));
> goto fail_destroy_client;
> }
> fcntl(clp->dir_fd, F_SETSIG, DNOTIFY_SIGNAL);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-05 16:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-02 4:57 [PATCH - nfs-utils] gssd: suppress error message if rpc_pipefs dir disappears NeilBrown
2013-09-05 16:02 ` Steve Dickson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).