From: Steve Dickson <SteveD@redhat.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] exportfs: test_export shouldn't use invalid uid/gid
Date: Tue, 24 Sep 2013 15:25:26 -0400 [thread overview]
Message-ID: <5241E726.6000100@RedHat.com> (raw)
In-Reply-To: <20130919191203.GA29599@fieldses.org>
On 19/09/13 15:12, J. Bruce Fields wrote:
> From: "J. Bruce Fields" <bfields@redhat.com>
>
> Some newer kernels are rejecting -1 uid/gid. Actually, worse--they're
> silently ignoring any attempt to cache such exports, thus preventing
> test_export from getting back the errors it needs.
>
> And -1 wasn't a good choice anyway.
>
> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Committed...
steved.
> ---
> utils/exportfs/exportfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/utils/exportfs/exportfs.c b/utils/exportfs/exportfs.c
> index 9f79541..4331697 100644
> --- a/utils/exportfs/exportfs.c
> +++ b/utils/exportfs/exportfs.c
> @@ -420,7 +420,7 @@ static int test_export(char *path, int with_fsid)
> char buf[1024];
> int fd, n;
>
> - sprintf(buf, "-test-client- %s 3 %d -1 -1 0\n",
> + sprintf(buf, "-test-client- %s 3 %d 65534 65534 0\n",
> path,
> with_fsid ? NFSEXP_FSID : 0);
> fd = open("/proc/net/rpc/nfsd.export/channel", O_WRONLY);
>
prev parent reply other threads:[~2013-09-24 19:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 19:12 [PATCH] exportfs: test_export shouldn't use invalid uid/gid J. Bruce Fields
2013-09-24 19:25 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5241E726.6000100@RedHat.com \
--to=steved@redhat.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).