* [PATCH] exportfs: test_export shouldn't use invalid uid/gid
@ 2013-09-19 19:12 J. Bruce Fields
2013-09-24 19:25 ` Steve Dickson
0 siblings, 1 reply; 2+ messages in thread
From: J. Bruce Fields @ 2013-09-19 19:12 UTC (permalink / raw)
To: steved; +Cc: linux-nfs
From: "J. Bruce Fields" <bfields@redhat.com>
Some newer kernels are rejecting -1 uid/gid. Actually, worse--they're
silently ignoring any attempt to cache such exports, thus preventing
test_export from getting back the errors it needs.
And -1 wasn't a good choice anyway.
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---
utils/exportfs/exportfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utils/exportfs/exportfs.c b/utils/exportfs/exportfs.c
index 9f79541..4331697 100644
--- a/utils/exportfs/exportfs.c
+++ b/utils/exportfs/exportfs.c
@@ -420,7 +420,7 @@ static int test_export(char *path, int with_fsid)
char buf[1024];
int fd, n;
- sprintf(buf, "-test-client- %s 3 %d -1 -1 0\n",
+ sprintf(buf, "-test-client- %s 3 %d 65534 65534 0\n",
path,
with_fsid ? NFSEXP_FSID : 0);
fd = open("/proc/net/rpc/nfsd.export/channel", O_WRONLY);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] exportfs: test_export shouldn't use invalid uid/gid
2013-09-19 19:12 [PATCH] exportfs: test_export shouldn't use invalid uid/gid J. Bruce Fields
@ 2013-09-24 19:25 ` Steve Dickson
0 siblings, 0 replies; 2+ messages in thread
From: Steve Dickson @ 2013-09-24 19:25 UTC (permalink / raw)
To: J. Bruce Fields; +Cc: linux-nfs
On 19/09/13 15:12, J. Bruce Fields wrote:
> From: "J. Bruce Fields" <bfields@redhat.com>
>
> Some newer kernels are rejecting -1 uid/gid. Actually, worse--they're
> silently ignoring any attempt to cache such exports, thus preventing
> test_export from getting back the errors it needs.
>
> And -1 wasn't a good choice anyway.
>
> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Committed...
steved.
> ---
> utils/exportfs/exportfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/utils/exportfs/exportfs.c b/utils/exportfs/exportfs.c
> index 9f79541..4331697 100644
> --- a/utils/exportfs/exportfs.c
> +++ b/utils/exportfs/exportfs.c
> @@ -420,7 +420,7 @@ static int test_export(char *path, int with_fsid)
> char buf[1024];
> int fd, n;
>
> - sprintf(buf, "-test-client- %s 3 %d -1 -1 0\n",
> + sprintf(buf, "-test-client- %s 3 %d 65534 65534 0\n",
> path,
> with_fsid ? NFSEXP_FSID : 0);
> fd = open("/proc/net/rpc/nfsd.export/channel", O_WRONLY);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-24 19:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-19 19:12 [PATCH] exportfs: test_export shouldn't use invalid uid/gid J. Bruce Fields
2013-09-24 19:25 ` Steve Dickson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).