From: Tony Asleson <tasleson@redhat.com>
To: NeilBrown <neilb@suse.de>
Cc: linux-nfs@vger.kernel.org, Steve Dickson <SteveD@redhat.com>
Subject: Re: [PATCH] exportfs: Return non-zero exit value on error
Date: Tue, 22 Oct 2013 10:23:14 -0500 [thread overview]
Message-ID: <52669862.6030409@redhat.com> (raw)
In-Reply-To: <20131022092519.4f4683a8@notabene.brown>
On 10/21/2013 05:25 PM, NeilBrown wrote:
> On Wed, 2 Oct 2013 18:29:44 -0500 Tony Asleson <tasleson@redhat.com> wrote:
>
>> To improve error handling when scripting exportfs it's useful
>> to have non-zero exit codes when the requested operation did not
>> succeed.
>>
>> This patch also returns a non-zero exit code if you request to
>> unexport a non-existant share.
>>
>> Signed-off-by: Tony Asleson <tasleson@redhat.com>
>
> This seems the have been forgotten, so maybe by replying to it someone will
> notice (hi Steve).
>
> Though I agree with the need for the patch, I don't much like it's shape.
>
> Why change exportfs and unexportfs to return a status? The status is only
> used to set export_errno, and they sometimes set export_errno anyway, so why
> not leave them returning void and just setting export_errno as needed?
The reason I chose to return values was to make sure requested operation
actually completed requested operation. Unexporting a non-existent
export is not considered an error and returns no indication you did
absolutely nothing.
When scripting exportfs from another program I wanted to know that the
operation I requested actually did what I asked so that I could catch
bad calls to it.
Regards,
Tony
next prev parent reply other threads:[~2013-10-22 15:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 23:29 [PATCH] exportfs: Return non-zero exit value on error Tony Asleson
2013-10-21 22:25 ` NeilBrown
2013-10-22 8:38 ` Steve Dickson
2013-10-22 15:23 ` Tony Asleson [this message]
2013-10-23 1:44 ` NeilBrown
2013-10-23 17:36 ` Tony Asleson
2013-10-23 22:18 ` NeilBrown
2013-10-23 23:31 ` Chuck Lever
2013-10-24 15:56 ` Steve Dickson
2013-10-24 16:05 ` Chuck Lever
2013-10-28 3:39 ` NeilBrown
2013-10-28 14:09 ` Chuck Lever
2013-10-24 5:34 ` Tony Asleson
2013-10-22 8:30 ` Steve Dickson
2013-10-22 8:36 ` Steve Dickson
2013-10-28 22:35 ` NeilBrown
2013-11-04 15:33 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52669862.6030409@redhat.com \
--to=tasleson@redhat.com \
--cc=SteveD@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).