From: Dave Quigley <dpquigl@davequigley.com>
To: "Myklebust, Trond" <Trond.Myklebust@netapp.com>,
Jeff Layton <jlayton@redhat.com>
Cc: "cye@redhat.com" <cye@redhat.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] nfs: fix oops when trying to set SELinux label
Date: Fri, 01 Nov 2013 22:41:37 -0400 [thread overview]
Message-ID: <52746661.60508@davequigley.com> (raw)
In-Reply-To: <1383324599.2911.2.camel@leira.trondhjem.org>
On 11/1/2013 12:50 PM, Myklebust, Trond wrote:
> On Fri, 2013-11-01 at 12:02 -0400, Jeff Layton wrote:
>> It looks like _nfs4_get_security_label() has the same problem, but I've
>> so far been unable to get it to be called, so I didn't patch it. It
>> seems like getxattr does some special stuff for SELinux labels that
>> cause them only to ever be fetched once.
>>
>> Is there some trick to it?
>>
>
> Doesn't 'ls -Z' cause them to security label to be read again?
>
> Either way, the fix is clearly needed, so I've added the patch, and Cced
> stable.
>
> Cheers
> Trond
>
ls -Z will only cause the label to be reread if its no longer valid in
the NFSv4 cache. Otherwise it will use the in-core inode value and
return that.
prev parent reply other threads:[~2013-11-02 2:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 14:49 [PATCH] nfs: fix oops when trying to set SELinux label Jeff Layton
2013-11-01 16:02 ` Jeff Layton
2013-11-01 16:50 ` Myklebust, Trond
2013-11-01 16:57 ` Jeff Layton
2013-11-01 17:05 ` Myklebust, Trond
2013-11-01 17:18 ` Jeff Layton
2013-11-01 17:47 ` Myklebust, Trond
2013-11-01 17:58 ` Jeff Layton
2013-11-01 18:29 ` Myklebust, Trond
2013-11-02 11:05 ` Jeff Layton
2013-11-02 2:46 ` Dave Quigley
2013-11-02 2:43 ` Dave Quigley
2013-11-02 2:41 ` Dave Quigley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52746661.60508@davequigley.com \
--to=dpquigl@davequigley.com \
--cc=Trond.Myklebust@netapp.com \
--cc=cye@redhat.com \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).